Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-21 Thread Mike Qiu
于 2013/7/19 22:32, Peter Maydell 写道: On 19 July 2013 15:12, Andreas Färber wrote: No, I don't. There were other segfault avoidance patches like yours over the past months - they're all fixing individual segfault symptoms. Question for Paolo is whether we want to continue to discover them one by

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-19 Thread Peter Maydell
On 19 July 2013 15:12, Andreas Färber wrote: > No, I don't. There were other segfault avoidance patches like yours over > the past months - they're all fixing individual segfault symptoms. > Question for Paolo is whether we want to continue to discover them one > by one or whether to implement a f

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-19 Thread Andreas Färber
Am 19.07.2013 04:26, schrieb Mike Qiu: > 于 2013/7/19 1:14, Andreas Färber 写道: >> There's some typos in the commit message, but the change looks okay to >> me - although there were discussions to catch this on the memory API >> side of things instead. > You mean this patch: see below: > > exec: Sup

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Mike Qiu
于 2013/7/19 1:14, Andreas Färber 写道: Hi, Am 18.07.2013 17:27, schrieb Mike Qiu: Hi all Any comments ? You should've CCed the USB maintainer whose file you are touching for review rather than just ppc people, see ./MAINTAINERS. I have CC to the usb naintainer Gerd Hoffmann, his files are hw/u

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Andreas Färber
Hi, Am 18.07.2013 17:27, schrieb Mike Qiu: > Hi all > > Any comments ? You should've CCed the USB maintainer whose file you are touching for review rather than just ppc people, see ./MAINTAINERS. There's some typos in the commit message, but the change looks okay to me - although there were dis

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Mike Qiu
Hi all Any comments ? Thanks Mike 2013/7/16 11:50, Mike Qiu wrote: > For usb-ehci in qemu, its caps just has read() operation, > the write() operation does not exist. > > This cause a Segmentation fault when use usb-ehci device in ppc64 > platform. > > here is gdb output: > > Program received sig

[Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-16 Thread Mike Qiu
For usb-ehci in qemu, its caps just has read() operation, the write() operation does not exist. This cause a Segmentation fault when use usb-ehci device in ppc64 platform. here is gdb output: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x3fffa7fcef20 (LWP 6793)] 0x0