Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works

2015-11-20 Thread Amit Shah
On (Thu) 19 Nov 2015 [15:27:48], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > madvise() returns EINVAL in the case of many failures, but also > returns it in cases where the host kernel doesn't have THP enabled. > Postcopy only really cares that THP is off before it de

Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works

2015-11-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > madvise() returns EINVAL in the case of many failures, but also > returns it in cases where the host kernel doesn't have THP enabled. > Postcopy only really cares that THP is off before it detects faults, > and turns it ba

[Qemu-devel] [PATCH] Assume madvise for (no)hugepage works

2015-11-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" madvise() returns EINVAL in the case of many failures, but also returns it in cases where the host kernel doesn't have THP enabled. Postcopy only really cares that THP is off before it detects faults, and turns it back on afterwards; so we're going to have to assume