Re: [Qemu-devel] [PATCH] Add trace messages to input.c.

2015-01-22 Thread Don Koch
On Thu, 22 Jan 2015 11:01:14 +0100 Gerd Hoffmann wrote: > Hi, > > > I believe this was used for debugging vmware mouse support we've been > > working on. > > Wouldn't it be more useful to trace qemu_input_handler_* calls for that, > especially qemu_input_handler_activate? So you also see cha

Re: [Qemu-devel] [PATCH] Add trace messages to input.c.

2015-01-22 Thread Gerd Hoffmann
Hi, > I believe this was used for debugging vmware mouse support we've been > working on. Wouldn't it be more useful to trace qemu_input_handler_* calls for that, especially qemu_input_handler_activate? So you also see changes triggered by the guest, such as enabling vmmouse, or initializing t

Re: [Qemu-devel] [PATCH] Add trace messages to input.c.

2015-01-19 Thread Don Koch
On Mon, 19 Jan 2015 08:34:22 +0100 Gerd Hoffmann wrote: > On Fr, 2015-01-16 at 14:08 -0500, Don Koch wrote: > > Signed-off-by: Don Koch > > > +trace_do_mouse_set(mon, index); > > First, I think we should have a better name for that one, maybe > "input_mouse_set" ? The trace name or the ro

Re: [Qemu-devel] [PATCH] Add trace messages to input.c.

2015-01-18 Thread Gerd Hoffmann
On Fr, 2015-01-16 at 14:08 -0500, Don Koch wrote: > Signed-off-by: Don Koch > +trace_do_mouse_set(mon, index); First, I think we should have a better name for that one, maybe "input_mouse_set" ? Second I'm wondering what the use case is. The place is a bit strange (tracing management not g

[Qemu-devel] [PATCH] Add trace messages to input.c.

2015-01-16 Thread Don Koch
Signed-off-by: Don Koch --- trace-events | 1 + ui/input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/trace-events b/trace-events index 97c7ac3..6a60f19 100644 --- a/trace-events +++ b/trace-events @@ -1136,6 +1136,7 @@ vnc_key_sync_numlock(bool on) "%d" vnc_key_sync_capslock(bool o