Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-28 Thread David Gibson
On Tue, Feb 28, 2017 at 08:32:17AM -0500, Mike Nawrocki wrote: > Signed-off-by: Mike Nawrocki > > Sorry, I was only testing against the ppc-softmmu and ppc64-softmmu targets. > I've now validated that this compiles against the following targets: > ppc-softmmu,ppc64-softmmu,ppcemb-softmmu,s390x-s

[Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-28 Thread Mike Nawrocki
Signed-off-by: Mike Nawrocki Sorry, I was only testing against the ppc-softmmu and ppc64-softmmu targets. I've now validated that this compiles against the following targets: ppc-softmmu,ppc64-softmmu,ppcemb-softmmu,s390x-softmmu,sh4-softmmu,ppc-linux-user,ppc64-linux-user,ppc64abi32-linux-user,

[Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-27 Thread Mike Nawrocki
Signed-off-by: Mike Nawrocki I've rebased my branch on master and regenerated the patch. I've run the patch through checkstyle.pl and it reported no issues, whitespace or otherwise. I suspect that Outlook was messing with my formatting, so let's give git send-email a go. Please let me know if

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-27 Thread da...@gibson.dropbear.id.au
On Wed, Feb 08, 2017 at 08:39:36PM +, Nawrocki, Michael wrote: > This patch extends support for the `dump-guest-memory` command to the 32-bit > PowerPC architecture. It relies on the assumption that a 64-bit guest will > not dump a 32-bit core file (and vice versa); if this assumption is inva

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-14 Thread Nawrocki, Michael
Hi Philippe, I rebased on the latest master, but the only difference between that patch and the emailed patch was the commit hash. I’m using master at git://git.qemu.org/qemu.git (latest commit 5dae13c). It seems to cleanly apply on my end… is there a different repo I should be working against,

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-14 Thread Philippe Mathieu-Daudé
Hi Mike, I failed to apply your patch on master: error: patch failed: target/ppc/Makefile.objs:1 error: target/ppc/Makefile.objs: patch does not apply error: patch failed: target/ppc/arch_dump.c:1 error: target/ppc/arch_dump.c: patch does not apply error: patch failed: target/ppc/cpu.h:1225 erro

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-09 Thread da...@gibson.dropbear.id.au
On Wed, Feb 08, 2017 at 08:39:36PM +, Nawrocki, Michael wrote: > This patch extends support for the `dump-guest-memory` command to > the 32-bit PowerPC architecture. It relies on the assumption that a > 64-bit guest will not dump a 32-bit core file (and vice versa); if > this assumption is inv

[Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

2017-02-08 Thread Nawrocki, Michael
This patch extends support for the `dump-guest-memory` command to the 32-bit PowerPC architecture. It relies on the assumption that a 64-bit guest will not dump a 32-bit core file (and vice versa); if this assumption is invalid, please let me know. Signed-off-by: Mike Nawrocki --- target/ppc/