Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-14 Thread andrzej zaborowski
On 12 December 2011 16:37, Dr. David Alan Gilbert wrote: > On ARM, don't map the code buffer at a fixed location, and fix up the > call/goto tcg routines to let it do long jumps. > > Mapping the code buffer at a fixed address could sometimes result in it being > mapped over the top of the heap wit

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread David Gilbert
On 12 December 2011 18:10, andrzej zaborowski wrote: > On 12 December 2011 19:03, Peter Maydell wrote: >> On 12 December 2011 17:24, andrzej zaborowski wrote: >>> BTW: I think we can also use the "ld" branch when we see the goto >>> target is in Thumb mode. >> >> The target of a goto is currentl

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread andrzej zaborowski
On 12 December 2011 19:03, Peter Maydell wrote: > On 12 December 2011 17:24, andrzej zaborowski wrote: >> BTW: I think we can also use the "ld" branch when we see the goto >> target is in Thumb mode. > > The target of a goto is currently never Thumb (because gotos are > always to other TCG genera

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread Peter Maydell
On 12 December 2011 17:24, andrzej zaborowski wrote: > BTW: I think we can also use the "ld" branch when we see the goto > target is in Thumb mode. The target of a goto is currently never Thumb (because gotos are always to other TCG generated code and we only generate ARM insns). If we did need t

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread andrzej zaborowski
Hi, On 12 December 2011 16:55, Peter Maydell wrote: > On 12 December 2011 15:37, Dr. David Alan Gilbert > wrote: >> On ARM, don't map the code buffer at a fixed location, and fix up the >> call/goto tcg routines to let it do long jumps. >> >> Mapping the code buffer at a fixed address could some

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread Peter Maydell
CC'ing Andrzej, who is the tcg/arm maintainer. On 12 December 2011 15:37, Dr. David Alan Gilbert wrote: > On ARM, don't map the code buffer at a fixed location, and fix up the > call/goto tcg routines to let it do long jumps. > > Mapping the code buffer at a fixed address could sometimes result i

[Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread Dr. David Alan Gilbert
On ARM, don't map the code buffer at a fixed location, and fix up the call/goto tcg routines to let it do long jumps. Mapping the code buffer at a fixed address could sometimes result in it being mapped over the top of the heap with pretty random results. This diff is against v1.0. Signed-off-by