Re: [Qemu-devel] [PATCH] 9pfs: fix v9fs_lock error case

2017-01-26 Thread Paolo Bonzini
On 26/01/2017 12:54, Greg Kurz wrote: > On Thu, 26 Jan 2017 11:07:05 +0100 > Paolo Bonzini wrote: > >> In this case, we are marshaling an error status instead of the errno value. >> Reorganize the out and out_nofid labels to look like all the other cases. >> Coverity reports this because the "e

Re: [Qemu-devel] [PATCH] 9pfs: fix v9fs_lock error case

2017-01-26 Thread Greg Kurz
On Thu, 26 Jan 2017 11:07:05 +0100 Paolo Bonzini wrote: > In this case, we are marshaling an error status instead of the errno value. > Reorganize the out and out_nofid labels to look like all the other cases. > Coverity reports this because the "err = -ENOENT" and "err = -EINVAL" > assignments a

[Qemu-devel] [PATCH] 9pfs: fix v9fs_lock error case

2017-01-26 Thread Paolo Bonzini
In this case, we are marshaling an error status instead of the errno value. Reorganize the out and out_nofid labels to look like all the other cases. Coverity reports this because the "err = -ENOENT" and "err = -EINVAL" assignments above are dead, overwritten by the call to pdu_marshal. Signed-off