Re: [Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-10-10 Thread Greg Kurz
On Tue, 27 Sep 2016 04:58:46 -0700 Li Qiang wrote: > From: Li Qiang > > In 9pfs read dispatch function, it doesn't free two QEMUIOVector > object thus causing potential memory leak. This patch avoid this. > > Signed-off-by: Li Qiang > --- Reviewed-by: Greg Kurz > hw/9pfs/9p.c | 5 +++-- >

Re: [Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-09-27 Thread Greg Kurz
On Tue, 27 Sep 2016 04:58:46 -0700 Li Qiang wrote: > From: Li Qiang > > In 9pfs read dispatch function, it doesn't free two QEMUIOVector > object thus causing potential memory leak. This patch avoid this. > > Signed-off-by: Li Qiang > --- When you post an updated version of a patch, you shou

[Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-09-27 Thread Li Qiang
From: Li Qiang In 9pfs read dispatch function, it doesn't free two QEMUIOVector object thus causing potential memory leak. This patch avoid this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index

Re: [Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-09-27 Thread Greg Kurz
On Mon, 26 Sep 2016 21:42:26 -0700 Li Qiang wrote: > From: Li Qiang > > In 9pfs read dispatch function, it doesn't free two QEMUIOVector > object thus causing potential memory leak. This patch avoid this. > Good catch for the leak, but I'd prefer another fix. See below. > Signed-off-by: Li Q

[Qemu-devel] [PATCH] 9pfs: fix potential host memory leak in v9fs_read

2016-09-26 Thread Li Qiang
From: Li Qiang In 9pfs read dispatch function, it doesn't free two QEMUIOVector object thus causing potential memory leak. This patch avoid this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index d960a2e..b1ff8e7