Re: [Qemu-devel] [PATCH] 9p: Print error hints if option parsing fails

2019-09-15 Thread Greg Kurz
On Sat, 14 Sep 2019 20:59:46 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > Option parsing fonctions are called with &error_fatal, which > > functions > > > causes error_setg() to call exit() and the hints are never > > printed. > > > > Use an intermediate error object so that exit(

Re: [Qemu-devel] [PATCH] 9p: Print error hints if option parsing fails

2019-09-14 Thread Markus Armbruster
Greg Kurz writes: > Option parsing fonctions are called with &error_fatal, which functions > causes error_setg() to call exit() and the hints are never > printed. > > Use an intermediate error object so that exit() happens in > error_propagate() after error_append_hint() could be called. Hmm.

[Qemu-devel] [PATCH] 9p: Print error hints if option parsing fails

2019-09-13 Thread Greg Kurz
Option parsing fonctions are called with &error_fatal, which causes error_setg() to call exit() and the hints are never printed. Use an intermediate error object so that exit() happens in error_propagate() after error_append_hint() could be called. Signed-off-by: Greg Kurz --- hw/9pfs/9p-local.