Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-09 Thread Wen Congyang
At 03/10/2011 12:31 PM, Ryan Harper Write: > * Wen Congyang [2011-03-09 01:21]: >> At 03/09/2011 02:12 PM, Ryan Harper Write: >>> * Wen Congyang [2011-03-08 23:09]: At 03/09/2011 12:08 PM, Ryan Harper Write: > * Wen Congyang [2011-02-27 20:56]: >> Hi Markus Armbruster >> >>

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-09 Thread Ryan Harper
* Wen Congyang [2011-03-09 01:21]: > At 03/09/2011 02:12 PM, Ryan Harper Write: > > * Wen Congyang [2011-03-08 23:09]: > >> At 03/09/2011 12:08 PM, Ryan Harper Write: > >>> * Wen Congyang [2011-02-27 20:56]: > Hi Markus Armbruster > > At 02/23/2011 04:30 PM, Markus Armbruster Writ

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-08 Thread Wen Congyang
At 03/09/2011 02:12 PM, Ryan Harper Write: > * Wen Congyang [2011-03-08 23:09]: >> At 03/09/2011 12:08 PM, Ryan Harper Write: >>> * Wen Congyang [2011-02-27 20:56]: Hi Markus Armbruster At 02/23/2011 04:30 PM, Markus Armbruster Write: > Isaku Yamahata writes: >

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-08 Thread Ryan Harper
* Wen Congyang [2011-03-08 23:09]: > At 03/09/2011 12:08 PM, Ryan Harper Write: > > * Wen Congyang [2011-02-27 20:56]: > >> Hi Markus Armbruster > >> > >> At 02/23/2011 04:30 PM, Markus Armbruster Write: > >>> Isaku Yamahata writes: > >>> > >> > >> > >> > >>> > >>> I don't think this patch is c

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-08 Thread Wen Congyang
At 03/09/2011 12:08 PM, Ryan Harper Write: > * Wen Congyang [2011-02-27 20:56]: >> Hi Markus Armbruster >> >> At 02/23/2011 04:30 PM, Markus Armbruster Write: >>> Isaku Yamahata writes: >>> >> >> >> >>> >>> I don't think this patch is correct. Let me explain. >>> >>> Device hot unplug is *not*

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-08 Thread Ryan Harper
* Wen Congyang [2011-02-27 20:56]: > Hi Markus Armbruster > > At 02/23/2011 04:30 PM, Markus Armbruster Write: > > Isaku Yamahata writes: > > > > > > > > > I don't think this patch is correct. Let me explain. > > > > Device hot unplug is *not* guaranteed to succeed. > > > > For some buse

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-03-01 Thread Isaku Yamahata
On Tue, Mar 01, 2011 at 03:32:08PM +0800, Wen Congyang wrote: > > The issue is, Qemu injected sci interrupt into guest, > > but before the guest completes to handled it, > > users/qemu can start to inject the next sci event triggered by hot > > plug/unplug. > > Thus qemu loses sci interrupt and up

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-28 Thread Wen Congyang
At 03/01/2011 03:13 PM, Isaku Yamahata Write: > On Tue, Mar 01, 2011 at 02:58:44PM +0800, Wen Congyang wrote: >> At 03/01/2011 12:11 PM, Isaku Yamahata Write: >>> Hi. >>> >>> I don't suppose that just introducing pending bits solve the issue. >>> Your test only use single hot plug/unplug. How about

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-28 Thread Isaku Yamahata
On Tue, Mar 01, 2011 at 02:58:44PM +0800, Wen Congyang wrote: > At 03/01/2011 12:11 PM, Isaku Yamahata Write: > > Hi. > > > > I don't suppose that just introducing pending bits solve the issue. > > Your test only use single hot plug/unplug. How about mixing of multiple > > hot plug/unplug with dif

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-28 Thread Wen Congyang
At 03/01/2011 12:11 PM, Isaku Yamahata Write: > Hi. > > I don't suppose that just introducing pending bits solve the issue. > Your test only use single hot plug/unplug. How about mixing of multiple > hot plug/unplug with different slots. The qemu uses the same thread to deal with monitor command

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-28 Thread Isaku Yamahata
Hi. I don't suppose that just introducing pending bits solve the issue. Your test only use single hot plug/unplug. How about mixing of multiple hot plug/unplug with different slots. Zeroing up/down on piix4_device_hotplug() is the culprit. State machine of (up, down) would be needed. (up, down) o

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-27 Thread Wen Congyang
Hi Markus Armbruster At 02/23/2011 04:30 PM, Markus Armbruster Write: > Isaku Yamahata writes: > > > I don't think this patch is correct. Let me explain. > > Device hot unplug is *not* guaranteed to succeed. > > For some buses, such as USB, it always succeeds immediately, i.e. when > the

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-23 Thread William Dauchy
Hi Markus, On Wed, Feb 23, 2011 at 9:30 AM, Markus Armbruster wrote: > I don't think this patch is correct.  Let me explain. > > Device hot unplug is *not* guaranteed to succeed. > > For some buses, such as USB, it always succeeds immediately, i.e. when > the device_del monitor command finishes,

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-23 Thread Markus Armbruster
Isaku Yamahata writes: > On Tue, Feb 22, 2011 at 06:36:20PM +0100, William Dauchy wrote: >> `qdev_free` when unplug a pci device >> It resolves a bug when detaching/attaching a network device >> >> # virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba >> Interface detached successful

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-22 Thread Isaku Yamahata
On Tue, Feb 22, 2011 at 06:36:20PM +0100, William Dauchy wrote: > `qdev_free` when unplug a pci device > It resolves a bug when detaching/attaching a network device > > # virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba > Interface detached successfully > > # virsh attach-interfac

[Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-22 Thread William Dauchy
`qdev_free` when unplug a pci device It resolves a bug when detaching/attaching a network device # virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba Interface detached successfully # virsh attach-interface dom0 network default --mac 52:54:00:f6:84:ba error: Failed to attach interf