Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 28/01/2014 11:55, Kirill A. Shutemov ha scritto: >> Currently we have few issues with P9_STATS_GEN: >> >> - We don't try to read st_gen anything except files or directories, but >>still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >>we present

Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 01:40:59PM +0200, Kirill A. Shutemov wrote: > Michael S. Tsirkin wrote: > > On Tue, Jan 28, 2014 at 12:55:51PM +0200, Kirill A. Shutemov wrote: > > > Currently we have few issues with P9_STATS_GEN: > > > > > > - We don't try to read st_gen anything except files or director

Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Kirill A. Shutemov
Michael S. Tsirkin wrote: > On Tue, Jan 28, 2014 at 12:55:51PM +0200, Kirill A. Shutemov wrote: > > Currently we have few issues with P9_STATS_GEN: > > > > - We don't try to read st_gen anything except files or directories, but > >still set P9_STATS_GEN bit in st_result_mask. It may mislead c

Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Michael S. Tsirkin
On Tue, Jan 28, 2014 at 12:55:51PM +0200, Kirill A. Shutemov wrote: > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit in st_result_mask. It may mislead client: >we present garbage as va

Re: [Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Paolo Bonzini
Il 28/01/2014 11:55, Kirill A. Shutemov ha scritto: Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we fa

[Qemu-devel] [PATCH] [RESEND-try-3] hw/9pfs: fix P9_STATS_GEN handling

2014-01-28 Thread Kirill A. Shutemov
Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid st_gen with ENOTTY, we ignore error,