Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2017-01-03 Thread Jean-Christophe DUBOIS
Le 03/01/2017 à 18:08, mar.krzeminski a écrit : You may still want to harden the m25p80 code to make sure it doesn't overrun its internal buffer. Yeap, for me it is a bug. I understand you will not finish this patch, won't you ?:) I could give it a shot. JC

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2017-01-03 Thread mar.krzeminski
W dniu 02.01.2017 o 22:24, Jean-Christophe DUBOIS pisze: Le 30/12/2016 à 19:09, mar.krzeminski a écrit : Can you check spi controller model code? I'll double check. But why is the SPI memory/device even responding if CS is not set ? Looking at ssi code it should not. Flash (so the m25p80)

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2017-01-02 Thread Jean-Christophe DUBOIS
Le 30/12/2016 à 19:09, mar.krzeminski a écrit : Can you check spi controller model code? I'll double check. But why is the SPI memory/device even responding if CS is not set ? Looking at ssi code it should not. Flash (so the m25p80) is responding when CS line is low and it seem that this is

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-30 Thread mar.krzeminski
W dniu 30.12.2016 o 18:14, Jean-Christophe DUBOIS pisze: Le 30/12/2016 à 16:39, mar.krzeminski a écrit : I got some time, and reproduced the problem. Here are some logs with m25p80 debugs: : decode_new_cmd: decoded new command:9f : decode_new_cmd: populated jedec code : decode_new_cmd: decode

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-30 Thread Jean-Christophe DUBOIS
Le 30/12/2016 à 16:39, mar.krzeminski a écrit : I got some time, and reproduced the problem. Here are some logs with m25p80 debugs: : decode_new_cmd: decoded new command:9f : decode_new_cmd: populated jedec code : decode_new_cmd: decoded new command:0 : decode_new_cmd: decoded new command:0 //Ge

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-30 Thread mar.krzeminski
W dniu 27.12.2016 o 18:08, Jean-Christophe DUBOIS pisze: You can have a more detailed procedure on how to run Xvisor on Qemu Sabrelite (with Linux guests if you wish) at the following URL. https://github.com/avpatel/xvisor-next/blob/master/docs/arm/imx6-sabrelite.txt You don't need to sta

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-27 Thread Jean-Christophe DUBOIS
You can have a more detailed procedure on how to run Xvisor on Qemu Sabrelite (with Linux guests if you wish) at the following URL. https://github.com/avpatel/xvisor-next/blob/master/docs/arm/imx6-sabrelite.txt You don't need to start the guest to see the crash. Just boot Xvisor ... JC Le 24/

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-24 Thread Jean-Christophe DUBOIS
Le 24/12/2016 à 19:04, mar.krzeminski a écrit : W dniu 24.12.2016 o 18:41, Jean-Christophe DUBOIS pisze: Le 24/12/2016 à 18:18, mar.krzeminski a écrit : Hello, W dniu 24.12.2016 o 16:11, Jean-Christophe Dubois pisze: It did happen that the internal data buffer was overrun leading to a Qemu

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-24 Thread mar.krzeminski
W dniu 24.12.2016 o 18:41, Jean-Christophe DUBOIS pisze: Le 24/12/2016 à 18:18, mar.krzeminski a écrit : Hello, W dniu 24.12.2016 o 16:11, Jean-Christophe Dubois pisze: It did happen that the internal data buffer was overrun leading to a Qemu crash (in particular while emulating the i.MX6 s

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-24 Thread Jean-Christophe DUBOIS
Le 24/12/2016 à 18:18, mar.krzeminski a écrit : Hello, W dniu 24.12.2016 o 16:11, Jean-Christophe Dubois pisze: It did happen that the internal data buffer was overrun leading to a Qemu crash (in particular while emulating the i.MX6 sabrelite board). This patch makes sure the data array would

Re: [Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-24 Thread mar.krzeminski
Hello, W dniu 24.12.2016 o 16:11, Jean-Christophe Dubois pisze: It did happen that the internal data buffer was overrun leading to a Qemu crash (in particular while emulating the i.MX6 sabrelite board). This patch makes sure the data array would not be overrun and allow the sabrelite emulation

[Qemu-devel] [PATCH] [M25P80] Make sure not to overrun the internal data buffer.

2016-12-24 Thread Jean-Christophe Dubois
It did happen that the internal data buffer was overrun leading to a Qemu crash (in particular while emulating the i.MX6 sabrelite board). This patch makes sure the data array would not be overrun and allow the sabrelite emulation to run without crash. Signed-off-by: Jean-Christophe Dubois ---