Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-19 Thread Paolo Bonzini
On 01/19/2012 10:16 AM, Chunyan Liu wrote: > Yes, that's true. He could have two definitions (SOCKET_PATH with %d and > SOCKET_PATH_HELP without) so that the occurrences would stay close in the > source code. Not clear how it will use SOCKET_PATH and SOCKET_PATH_HELP. SOCKET_PATH_HELP stores

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-19 Thread Chunyan Liu
2012/1/18 Paolo Bonzini : > On 01/18/2012 11:56 AM, Michael Tokarev wrote: >> >> On 18.01.2012 12:48, Chunyan Liu wrote: >>> >>> Stefan, could you help commit it if it's OK? Thanks. >>> Same as in thread: >>> http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html >>> but rebase it to la

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-19 Thread Paolo Bonzini
On 01/19/2012 09:52 AM, Chunyan Liu wrote: Currently, to print the connected device name, we can also change code a little as following: ("-v" can still indicate working on background or not. ) Unfortunately not, that will cause the parent to exit with a status code of 1. Paolo

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-19 Thread Chunyan Liu
Thanks, Paolo! 2012/1/18 Paolo Bonzini : > On 01/18/2012 09:48 AM, Chunyan Liu wrote: >> >> Stefan, could you help commit it if it's OK? Thanks. >> Same as in thread: >> http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html >> but rebase it to latest code. >> >> Add -f option to qemu-

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 11:56 AM, Michael Tokarev wrote: On 18.01.2012 12:48, Chunyan Liu wrote: Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. There's a (trivial) fix sent against q

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Michael Tokarev
On 18.01.2012 12:48, Chunyan Liu wrote: > Stefan, could you help commit it if it's OK? Thanks. > Same as in thread: > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html > but rebase it to latest code. There's a (trivial) fix sent against qemu-nbd which will make this patch to not a

Re: [Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Paolo Bonzini
On 01/18/2012 09:48 AM, Chunyan Liu wrote: Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. Add -f option to qemu-nbd to find a free nbd device for user and connect disk image

[Qemu-devel] [PATCH][resend] Add -f option to qemu-nbd

2012-01-18 Thread Chunyan Liu
Stefan, could you help commit it if it's OK? Thanks. Same as in thread: http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg01083.html but rebase it to latest code. Add -f option to qemu-nbd to find a free nbd device for user and connect disk image to that device. syntax: qemu-nbd -f disk.img