Sarah Khan writes:
> util/envlist.c:This patch replaces malloc with g_malloc
>
> This replacement was suggested as part of the bite-sized tasks.
>
> Signed-off-by: Sarah Khan
Thanks for your contribution. A few notes for the next revision.
It's always worth running $SRC/scripts/checkpatch.pl
On 05/03/2016 07:45, Sarah Khan wrote:
> util/envlist.c:This patch replaces malloc with g_malloc
This should be placed in the subject. Please follow the instructions at
http://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches to
format the patch correctly.
> - if ((envlist = ma
util/envlist.c:This patch replaces malloc with g_malloc
This replacement was suggested as part of the bite-sized tasks.
Signed-off-by: Sarah Khan
--
diff --git a/util/envlist.c b/util/envlist.c
index e86857e..0324fe2 100644
--- a/util/envlist.c
+++ b/util/envlist.c
@@ -25,7 +25,7 @@ env
On 4 March 2016 at 16:35, Eric Blake wrote:
> On 03/04/2016 09:06 AM, Peter Maydell wrote:
>
+++ b/thunk.c
@@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name,
const argtype *types)
for(i = 0;i < 2; i++) {
offset = 0;
max_alig
On 03/04/2016 09:06 AM, Peter Maydell wrote:
>>> +++ b/thunk.c
>>> @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name,
>>> const argtype *types)
>>> for(i = 0;i < 2; i++) {
>>> offset = 0;
>>> max_align = 1;
>>> -se->field_offsets[i] = malloc(nb_f
Ok. Will complete the required.
Thanks,
Sarah
On 4 March 2016 at 15:44, Eric Blake wrote:
> On 03/04/2016 07:53 AM, Sarah Khan wrote:
>> This patch replaces malloc() with g_malloc() as stated to be done in
bitesized task
>>
>> diff --git a/thunk.c b/thunk.c
>> index f057d86..bddabae 100644
>> ---
On 4 March 2016 at 15:44, Eric Blake wrote:
> On 03/04/2016 07:53 AM, Sarah Khan wrote:
>> This patch replaces malloc() with g_malloc() as stated to be done in
>> bitesized task
>>
>> diff --git a/thunk.c b/thunk.c
>> index f057d86..bddabae 100644
>> --- a/thunk.c
>> +++ b/thunk.c
>> @@ -88,7 +88
On 03/04/2016 08:49 AM, Eric Blake wrote:
> Oh, I see you DID include a S-o-b, but in the subject line of the patch
> instead of the commit body. Which still needs work. You need a
> one-line summary as the subject, not your S-o-b, so the commit message
> should look more like:
>
> thunk: Repla
On 03/04/2016 08:44 AM, Eric Blake wrote:
> On 03/04/2016 07:53 AM, Sarah Khan wrote:
>> This patch replaces malloc() with g_malloc() as stated to be done in
>> bitesized task
>>
>> diff --git a/thunk.c b/thunk.c
>> index f057d86..bddabae 100644
>> --- a/thunk.c
>> +++ b/thunk.c
>> @@ -88,7 +88,7
On 03/04/2016 07:53 AM, Sarah Khan wrote:
> This patch replaces malloc() with g_malloc() as stated to be done in
> bitesized task
>
> diff --git a/thunk.c b/thunk.c
> index f057d86..bddabae 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *n
This patch replaces malloc() with g_malloc() as stated to be done in bitesized
task
diff --git a/thunk.c b/thunk.c
index f057d86..bddabae 100644
--- a/thunk.c
+++ b/thunk.c
@@ -88,7 +88,7 @@ void thunk_register_struct(int id, const char *name, const
argtype *types)
for(i = 0;i < 2; i++) {
11 matches
Mail list logo
