Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-05-10 Thread Avi Kivity
On 05/10/2012 01:49 PM, Jan Kiszka wrote: > On 2012-05-10 06:27, Avi Kivity wrote: > > On 05/10/2012 01:23 AM, Anthony Liguori wrote: > >> On 04/04/2012 03:41 AM, Avi Kivity wrote: > >>> On 04/04/2012 04:15 AM, David Gibson wrote: > If the kernel page size is larger than TARGET_PAGE_SIZE, whic

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-05-10 Thread Jan Kiszka
On 2012-05-10 06:27, Avi Kivity wrote: > On 05/10/2012 01:23 AM, Anthony Liguori wrote: >> On 04/04/2012 03:41 AM, Avi Kivity wrote: >>> On 04/04/2012 04:15 AM, David Gibson wrote: If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels com

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-05-10 Thread Avi Kivity
On 05/10/2012 01:23 AM, Anthony Liguori wrote: > On 04/04/2012 03:41 AM, Avi Kivity wrote: >> On 04/04/2012 04:15 AM, David Gibson wrote: >>> If the kernel page size is larger than TARGET_PAGE_SIZE, which >>> happens for example on ppc64 with kernels compiled for 64K pages, >>> the dirty tracking d

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-05-09 Thread Anthony Liguori
On 04/04/2012 03:41 AM, Avi Kivity wrote: On 04/04/2012 04:15 AM, David Gibson wrote: If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tosatti Thanks, a

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-05 Thread Jan Kiszka
On 2012-04-04 16:24, David Gibson wrote: > On Wed, Apr 04, 2012 at 12:58:37PM +0200, Jan Kiszka wrote: >> On 2012-04-04 03:12, David Gibson wrote: Also, what's about coalesced MMIO? I see that the ring definition depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread David Gibson
On Wed, Apr 04, 2012 at 12:58:37PM +0200, Jan Kiszka wrote: > On 2012-04-04 03:12, David Gibson wrote: > >> Also, what's about coalesced MMIO? I see that the ring definition > >> depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use > >> for it, and does it make a relevant differe

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread Jan Kiszka
On 2012-04-04 03:12, David Gibson wrote: >> Also, what's about coalesced MMIO? I see that the ring definition >> depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use >> for it, and does it make a relevant difference for space? > > Hr, so the HV variant of Power KVM doesn't do co

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-04 Thread Avi Kivity
On 04/04/2012 04:15 AM, David Gibson wrote: > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tosatti > Thanks, applied to uq/master. -- I have

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-03 Thread David Gibson
On Tue, Apr 03, 2012 at 09:08:16AM +0200, Jan Kiszka wrote: > On 2012-04-02 06:04, David Gibson wrote: > > From: Ben Herrenschmidt > > > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > > happens for example on ppc64 with kernels compiled for 64K pages, > > the dirty tracking do

[Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-03 Thread David Gibson
If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tosatti Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- kvm-all.c | 14

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-03 Thread Jan Kiszka
On 2012-04-02 06:04, David Gibson wrote: > From: Ben Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. > > Cc: Avi Kivity > Cc: Marcelo Tosatti > > Signed-off-

Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-01 Thread Benjamin Herrenschmidt
On Mon, 2012-04-02 at 14:04 +1000, David Gibson wrote: > From: Ben Herrenschmidt > > If the kernel page size is larger than TARGET_PAGE_SIZE, which > happens for example on ppc64 with kernels compiled for 64K pages, > the dirty tracking doesn't work. BTW. That was discussed ages back on the list

[Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size

2012-04-01 Thread David Gibson
From: Ben Herrenschmidt If the kernel page size is larger than TARGET_PAGE_SIZE, which happens for example on ppc64 with kernels compiled for 64K pages, the dirty tracking doesn't work. Cc: Avi Kivity Cc: Marcelo Tosatti Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson ---