Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-06 Thread Lan, Tianyu
On 10/6/2015 9:49 PM, Stefano Stabellini wrote: On Tue, 6 Oct 2015, Paolo Bonzini wrote: On 05/10/2015 18:53, Stefano Stabellini wrote: This patch is to fix the issue via moving MSIX MMIO memory region into struct XenPCIPassthroughState and free it together with pt device's obj. Given that

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-06 Thread Stefano Stabellini
On Tue, 6 Oct 2015, Paolo Bonzini wrote: > On 05/10/2015 18:53, Stefano Stabellini wrote: > >> This patch is to fix the issue via moving MSIX MMIO memory region into > >> struct XenPCIPassthroughState and free it together with pt device's obj. > > > > Given that all the MSI-X related info are in X

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-06 Thread Paolo Bonzini
On 05/10/2015 18:53, Stefano Stabellini wrote: >> This patch is to fix the issue via moving MSIX MMIO memory region into >> struct XenPCIPassthroughState and free it together with pt device's obj. > > Given that all the MSI-X related info are in XenPTMSIX, I would prefer > to keep the mmio memor

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-05 Thread Stefano Stabellini
Hi Lan, thanks for the patch. On Wed, 30 Sep 2015, Lan Tianyu wrote: > MSIX MMIO memory region is added to pt device's obj as property. msix->mmio is added to XenPCIPassthroughState's object as property > When pt device is unplugged, all properties will be deleted and > memory region's obj is n

[Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-01 Thread Lan Tianyu
MSIX MMIO memory region is added to pt device's obj as property. When pt device is unplugged, all properties will be deleted and memory region's obj is needed at that point(refer object_finalize_child_property()). But current code frees MSIX MMIO memory region in the xen_pt_msix_delete() before de