[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-09-08 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 2.0.0+dfsg-2ubuntu1.18 --- qemu (2.0.0+dfsg-2ubuntu1.18) trusty-proposed; urgency=medium * qemu-nbd-fix-vdi-corruption.patch: qemu-nbd: fix corruption while writing VDI volumes (LP: #1422307) -- Pierre Schweitzer Mon, 17 Aug 2015 11:4

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Pierre Schweitzer
Tested 2.0.0+dfsg-2ubuntu1.18. Cannot reproduce the issue. TEST CASE 1: Attempt several times to copy files on a VDI disk, and couldn't trigger any corruption (nor deadlock - no regression). Given my test scenario, previously, I would already have hit the corruption. TEST CASE 2: Tested with t

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Pierre Schweitzer
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts files Status in QEMU: Fix Released Status in

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Brian Murray
Hello Pierre, or anyone else affected, Accepted qemu into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/2.0.0+dfsg- 2ubuntu1.18 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-26 Thread Serge Hallyn
** Changed in: qemu (Ubuntu Trusty) Assignee: Serge Hallyn (serge-hallyn) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts files Status in QEMU:

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-26 Thread Serge Hallyn
** Changed in: qemu (Ubuntu Trusty) Importance: Medium => High ** Changed in: qemu (Ubuntu Trusty) Assignee: (unassigned) => Serge Hallyn (serge-hallyn) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-19 Thread Pierre Schweitzer
Please find attach a proposed debdiff for fixing the issue in Ubuntu Trusty by backporting the fix which is now in Wily. ** Description changed: + [Impact] + A race condition in the VDI block driver of Qemu leads to image (and thus file system) corruption under certain circumstances. + This make

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-17 Thread Robie Basak
And since Ubuntu Wily ships 2.3, I presume this is also fixed in Ubuntu in Wily. I'll mark that Fix Released too, and add a task for Trusty. ** Changed in: qemu (Ubuntu) Status: New => Fix Released ** Also affects: qemu (Ubuntu Trusty) Importance: Undecided Status: New ** Change

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-17 Thread Robie Basak
Based on Max's comment this is Fix Released upstream. ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-07-06 Thread Pierre Schweitzer
Thanks for the extra information. I'll open a new bug report at Ubuntu to get the fix backported to Trusty. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts f

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-07-06 Thread Max Reitz
Hi Nicolas, It (that is, its v2) has been merged into upstream master (http://git.qemu.org/?p=qemu.git;a=commit;h=f0ab6f109630940146cbaf47d0cd3ddba824) and is part of qemu 2.3.0 (and will probably become part of 2.2.2, too). Max -- You received this bug notification because you are a member

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-07-06 Thread Nicolas Rüegg
Hi, Has this patch already been incorporated? I'm observing the bug as well when copying files into a VDI image. Kind regards, Nicolas -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title:

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-04-09 Thread Pierre Schweitzer
Hi, Was the patch abandoned? I haven't seen any further progress on it for a month... Cheers, -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts files Status in QEMU:

Re: [Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-23 Thread Stefan Hajnoczi
On Thu, Feb 19, 2015 at 05:48:03PM -, Pierre Schweitzer wrote: > Thanks Max & Stefan. > > Could you please let me know when the commit makes it to the QEMU > repository? And give me its commit ID? > > So that I can ask for a bugfix backport in Trusty. Hi Pierre, In case I forget, please foll

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-19 Thread Pierre Schweitzer
Thanks Max & Stefan. Could you please let me know when the commit makes it to the QEMU repository? And give me its commit ID? So that I can ask for a bugfix backport in Trusty. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

Re: [Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-18 Thread Stefan Hajnoczi
On Wed, Feb 18, 2015 at 09:11:57AM -, Pierre Schweitzer wrote: > Does that mean it can also affect VMs running with VDI disk(s)? Yes, that's what Max's example showed. Note that only raw, qcow2, and qed support in QEMU is designed for running guests. The other formats like vmdk and vdi are m

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-18 Thread Pierre Schweitzer
So, if I understand well, it's "just" some kind of race condition in the handling of writes in the VDI driver of Qemu? Does that mean it can also affect VMs running with VDI disk(s)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
Adding some locking in qemu's VDI implementation makes the bug disappear, at least I can't reproduce it anymore. I'll send a patch. Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title:

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
I succeeded to reproduce the bug without NBD: $ ./qemu-img create -f vdi test.vdi 2G Formatting 'test.vdi', fmt=vdi size=2147483648 static=off $ ./qemu-img create -f raw test.raw 2G Formatting 'test.raw', fmt=raw size=2147483648 $ x86_64-softmmu/qemu-system-x86_64 -enable-kvm -drive if=virtio,fil

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
First insight: Having the VDI image in tmpfs or using --cache=none for qemu-nbd changes nothing, therefore the reason why dropping the caches affects the result is probably Linux's cache for the NBD block device. Second insight: Using blkverify makes it look very much like qemu's VDI implementatio

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
For whatever reason, using an empty image now works for me, too: $ ./qemu-img create -f vdi test.vdi 64M; ./qemu-nbd -c /dev/nbd0 test.vdi; dd if=/dev/urandom of=/dev/nbd0 bs=1K count=16384; md5sum /dev/nbd0; sync; echo 1 > /proc/sys/vm/drop_caches; md5sum /dev/nbd0; ./qemu-nbd -d /dev/nbd0 Form

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
Hi Pierre, I can reproduce the bug with a 2 GB VDI image with a single FAT32-formatted partition (on git master): # cp src.vdi test.vdi # ./qemu-nbd -c /dev/nbd0 test.vdi # dd if=/dev/urandom of=/dev/nbd0 bs=1M count=64 64+0 records in 64+0 records out 67108864 bytes (67 MB) copied, 3.34091 s, 20

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-02-17 Thread Max Reitz
** Attachment added: "src.qcow2" https://bugs.launchpad.net/qemu/+bug/1422307/+attachment/4321013/+files/src.qcow2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts