Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-16 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 06:45:57PM +, Peter Maydell wrote: > On 15 March 2017 at 18:08, Daniel P. Berrange wrote: > > On Wed, Mar 15, 2017 at 06:00:40PM +, Peter Maydell wrote: > >> On 15 March 2017 at 17:46, Simon wrote: > >> > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-16 Thread Simon
Hi Peter, Why can't we use SIGHUP, again? I suppose for all those people who use non ACPI-aware guests in non daemonized Qemu instances and usually close their terminal without stopping Qemu first on the assumption that Qemu will stop itself automatically: this wouldn't work anymore... More s

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 18:08, Daniel P. Berrange wrote: > On Wed, Mar 15, 2017 at 06:00:40PM +, Peter Maydell wrote: >> On 15 March 2017 at 17:46, Simon wrote: >> > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the >> > same behavior. >> > >> > SIGQUIT is reserved for core

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 06:00:40PM +, Peter Maydell wrote: > On 15 March 2017 at 17:46, Simon wrote: > > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the > > same behavior. > > > > SIGQUIT is reserved for core files generation. > > > > SIGUSR1 is already used in 'util/qe

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Peter Maydell
On 15 March 2017 at 17:46, Simon wrote: > OK for not using SIGHUP and keep SIGTERM, SIGINT and SIGHUP to have the > same behavior. > > SIGQUIT is reserved for core files generation. > > SIGUSR1 is already used in 'util/qemu-progress.c' to trigger a report > on ongoing jobs, so it does not seem usa

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Simon
Daniel P. Berrange: While I understand your motivation this creates a semantic change for existing users of QEMU. IOW anyone who is currently relying on use of SIGHUP will experiance a regression when upgrading QEMU. So if we want to signal to generate a clean shutdown, we need to pick one that

Re: [Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 02:45:57PM +0100, Simon wrote: > Hello, > > Here is a short patch answering to Qemu wish-list issue 1217339. > > It makes Qemu to cleanly power off the guest when receiving a SIGHUP > signal, thus without requiring any monitor

[Qemu-devel] [Bug 1217339] [PATCH] Unix signal to send ACPI-shutdown to Guest

2017-03-15 Thread Simon
Hello, Here is a short patch answering to Qemu wish-list issue 1217339. It makes Qemu to cleanly power off the guest when receiving a SIGHUP signal, thus without requiring any monitor access which is currently impossible (AFAIK). The original issue