On 2015-01-17 19:55:16, Peter Maydell wrote:
>On 17 January 2015 at 11:52, Peter Maydell wrote:
> > On 17 January 2015 at 06:48, Zhang Haoyu wrote:
> >> G_IO_OUT|G_IO_HUP are passed from all of the callers
> >> of chr_add_watch hooker, the assert condition MUST be
> >> changed.
>>
> > "All the c
On 17 January 2015 at 11:52, Peter Maydell wrote:
> On 17 January 2015 at 06:48, Zhang Haoyu wrote:
>> G_IO_OUT|G_IO_HUP are passed from all of the callers
>> of chr_add_watch hooker, the assert condition MUST be
>> changed.
>
> "All the callers do this currently" isn't a reason to
> change an as
On 17 January 2015 at 06:48, Zhang Haoyu wrote:
> G_IO_OUT|G_IO_HUP are passed from all of the callers
> of chr_add_watch hooker, the assert condition MUST be
> changed.
"All the callers do this currently" isn't a reason to
change an assert. Possible reasons to change it include:
* "X is require
G_IO_OUT|G_IO_HUP are passed from all of the callers
of chr_add_watch hooker, the assert condition MUST be
changed.
Signed-off-by: Zhang Haoyu
---
spice-qemu-char.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 7e0d300..b81a9db 10
