Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

On Mon, Nov 21, 2022 at 02:07:41AM -0500, Michael S. Tsirkin wrote: On Mon, Nov 21, 2022 at 02:17:02PM +0800, Jason Wang wrote: On Sun, Nov 20, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > On Fri, Nov 18, 2022 at 03:32:56PM +0100, Stefano Garzarella wrote: > > Hi, > > starting from this commit

Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

On Mon, Nov 21, 2022 at 02:17:02PM +0800, Jason Wang wrote: > On Sun, Nov 20, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > > > On Fri, Nov 18, 2022 at 03:32:56PM +0100, Stefano Garzarella wrote: > > > Hi, > > > starting from this commit 69e1c14aa2 ("virtio: core: vq reset feature > > > negotation

Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

On Sun, Nov 20, 2022 at 1:19 AM Michael S. Tsirkin wrote: > > On Fri, Nov 18, 2022 at 03:32:56PM +0100, Stefano Garzarella wrote: > > Hi, > > starting from this commit 69e1c14aa2 ("virtio: core: vq reset feature > > negotation support"), vhost-user-vsock and vhost-vsock fails while > > setting the

Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

On Fri, Nov 18, 2022 at 03:32:56PM +0100, Stefano Garzarella wrote: > Hi, > starting from this commit 69e1c14aa2 ("virtio: core: vq reset feature > negotation support"), vhost-user-vsock and vhost-vsock fails while > setting the device features, because VIRTIO_F_RING_RESET is not masked. > > I'm

Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

On Fri, Nov 18, 2022 at 3:32 PM Stefano Garzarella wrote: > > Hi, > starting from this commit 69e1c14aa2 ("virtio: core: vq reset feature > negotation support"), vhost-user-vsock and vhost-vsock fails while > setting the device features, because VIRTIO_F_RING_RESET is not masked. vhost-vsock issu

Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support

Hi, starting from this commit 69e1c14aa2 ("virtio: core: vq reset feature negotation support"), vhost-user-vsock and vhost-vsock fails while setting the device features, because VIRTIO_F_RING_RESET is not masked. I'm not sure vsock is the only one affected. We could fix in two ways: 1) Masking

[PULL v4 30/83] virtio: core: vq reset feature negotation support

From: Kangjie Xu A a new command line parameter "queue_reset" is added. Meanwhile, the vq reset feature is disabled for pre-7.2 machines. Signed-off-by: Kangjie Xu Signed-off-by: Xuan Zhuo Acked-by: Jason Wang Message-Id: <20221017092558.111082-5-xuanz...@linux.alibaba.com> Reviewed-by: Mich