Re: [PULL v2 48/65] libvhost-user: make it a meson subproject

2020-12-10 Thread Peter Maydell
On Thu, 10 Dec 2020 at 16:17, Paolo Bonzini wrote: > > On Thu, Dec 10, 2020 at 5:11 PM Peter Maydell > wrote: > > Looking at the commit, it's not clear to me why the > > vhost-user changes have resulted in all binaries getting > > a change to their link line. Paolo ? > > Because libvhost-user/me

Re: [PULL v2 48/65] libvhost-user: make it a meson subproject

2020-12-10 Thread Paolo Bonzini
On Thu, Dec 10, 2020 at 5:11 PM Peter Maydell wrote: > Looking at the commit, it's not clear to me why the > vhost-user changes have resulted in all binaries getting > a change to their link line. Paolo ? Because libvhost-user/meson.build is not using the GLIB flags from QEMU's configure and is n

Re: [PULL v2 48/65] libvhost-user: make it a meson subproject

2020-12-10 Thread Peter Maydell
On Wed, 9 Dec 2020 at 18:10, Michael S. Tsirkin wrote: > > From: Marc-André Lureau > > By making libvhost-user a subproject, check it builds > standalone (without the global QEMU cflags etc). > > Note that the library still relies on QEMU include/qemu/atomic.h and > linux_headers/. > > Signed-off

[PULL v2 48/65] libvhost-user: make it a meson subproject

2020-12-09 Thread Michael S. Tsirkin
From: Marc-André Lureau By making libvhost-user a subproject, check it builds standalone (without the global QEMU cflags etc). Note that the library still relies on QEMU include/qemu/atomic.h and linux_headers/. Signed-off-by: Marc-André Lureau Message-Id: <20201125100640.366523-6-marcandre.lu