Re: [PULL v2 07/14] accel/tcg: Use interval tree for user-only page tracking

2022-12-24 Thread Richard Henderson
On 12/23/22 06:32, Ilya Leoshkevich wrote: +mmap_lock(); +p = pageflags_find(address, address); +mmap_unlock(); How does the code ensure that p is not freed here? +return p ? p->flags : 0; Yep, need to use g_free_rcu. +while (true) { +PageFlagsNode *p = pagefla

Re: [PULL v2 07/14] accel/tcg: Use interval tree for user-only page tracking

2022-12-23 Thread Ilya Leoshkevich
On Tue, Dec 20, 2022 at 09:03:06PM -0800, Richard Henderson wrote: > Finish weaning user-only away from PageDesc. > > Using an interval tree to track page permissions means that > we can represent very large regions efficiently. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/290 > Re

[PULL v2 07/14] accel/tcg: Use interval tree for user-only page tracking

2022-12-20 Thread Richard Henderson
Finish weaning user-only away from PageDesc. Using an interval tree to track page permissions means that we can represent very large regions efficiently. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/290 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/967 Resolves: https://gitla