Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Marc-André Lureau
Hi On Thu, Apr 6, 2023 at 7:00 PM Stefan Berger wrote: > > > > On 4/6/23 10:36, Peter Maydell wrote: > > On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote: > >> I'll be out starting tomorrow. I don't see Marc-André online. > >> > >> Would this be acceptable? > >> It ensures that if error_handle()

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Markus Armbruster
Stefan Berger writes: > On 4/6/23 09:17, Peter Maydell wrote: >> On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote: >>> >>> On Mon, 13 Mar 2023 at 11:47, wrote: From: Marc-André Lureau This can help debugging issues or develop, when error handling is introduced. >>

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Peter Maydell
On Thu, 6 Apr 2023 at 16:00, Stefan Berger wrote: > > > > On 4/6/23 10:36, Peter Maydell wrote: > > On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote: > >> I'll be out starting tomorrow. I don't see Marc-André online. > >> > >> Would this be acceptable? > >> It ensures that if error_handle() retur

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Stefan Berger
On 4/6/23 10:36, Peter Maydell wrote: On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote: I'll be out starting tomorrow. I don't see Marc-André online. Would this be acceptable? It ensures that if error_handle() returns, err has been freed. In the other two cases a copy is being made of the E

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Peter Maydell
On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote: > I'll be out starting tomorrow. I don't see Marc-André online. > > Would this be acceptable? > It ensures that if error_handle() returns, err has been freed. > In the other two cases a copy is being made of the Error that can then be > used after

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Stefan Berger
On 4/6/23 09:17, Peter Maydell wrote: On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote: On Mon, 13 Mar 2023 at 11:47, wrote: From: Marc-André Lureau This can help debugging issues or develop, when error handling is introduced. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berg

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Peter Maydell
On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote: > > On Mon, 13 Mar 2023 at 11:47, wrote: > > > > From: Marc-André Lureau > > > > This can help debugging issues or develop, when error handling is > > introduced. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Stefan Berger > > Messa

Re: [PULL v2 05/25] error: add global &error_warn destination

2023-04-06 Thread Peter Maydell
On Mon, 13 Mar 2023 at 11:47, wrote: > > From: Marc-André Lureau > > This can help debugging issues or develop, when error handling is > introduced. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Stefan Berger > Message-Id: <20230221124802.4103554-6-marcandre.lur...@redhat.com> Hi; Coveri

[PULL v2 05/25] error: add global &error_warn destination

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau This can help debugging issues or develop, when error handling is introduced. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20230221124802.4103554-6-marcandre.lur...@redhat.com> --- include/qapi/error.h | 6 ++ tests/unit/test-