Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 12:29:43PM -0400, Peter Xu wrote: > > > CID 1527402: In migrate_fd_cleanup() Coverity thinks there's > > > a race because we read s->to_dst_file in the "if (s->to_dst_file)" > > > check without holding the qemu_file_lock. This might be a > > > false-positive because the race

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 11:05:28AM -0300, Fabiano Rosas wrote: > Peter Maydell writes: > > > On Thu, 19 Sept 2024 at 12:59, Peter Xu wrote: > >> > >> On Thu, Sep 19, 2024 at 10:08:25AM +0100, Peter Maydell wrote: > >> > Thanks for looking at the issues with the migration tests. > >> > This run w

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Fabiano Rosas
Peter Maydell writes: > On Thu, 19 Sept 2024 at 12:59, Peter Xu wrote: >> >> On Thu, Sep 19, 2024 at 10:08:25AM +0100, Peter Maydell wrote: >> > Thanks for looking at the issues with the migration tests. >> > This run went through first time without my needing to retry any >> > jobs, so fingers

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Maydell
On Thu, 19 Sept 2024 at 12:59, Peter Xu wrote: > > On Thu, Sep 19, 2024 at 10:08:25AM +0100, Peter Maydell wrote: > > Thanks for looking at the issues with the migration tests. > > This run went through first time without my needing to retry any > > jobs, so fingers crossed that we have at least i

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 10:08:25AM +0100, Peter Maydell wrote: > Thanks for looking at the issues with the migration tests. > This run went through first time without my needing to retry any > jobs, so fingers crossed that we have at least improved the reliability. > (I have a feeling there's still

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Maydell
On Wed, 18 Sept 2024 at 19:31, Peter Xu wrote: > > The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2024-09-17 14:02:18 +0100) > > are available in the Git repository at: > > htt

[PULL v2 0/6] Migration 20240917 patches

2024-09-18 Thread Peter Xu
The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2024-09-17 14:02:18 +0100) are available in the Git repository at: https://gitlab.com/peterx/qemu.git tags/migration-20240917-pull-re