Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2024-07-25 Thread Peter Maydell
On Tue, 19 Dec 2023 at 13:36, Peter Maydell wrote: > > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > From: David Woodhouse > > > > The way that Xen handles MSI PIRQs is kind of awful. > > > > There is a special MSI message which targets a PIRQ. The vector in the > > low bits of data

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-12-19 Thread Peter Maydell
On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > From: David Woodhouse > > The way that Xen handles MSI PIRQs is kind of awful. > > There is a special MSI message which targets a PIRQ. The vector in the > low bits of data must be zero. The low 8 bits of the PIRQ# are in the > destination ID

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-07-04 Thread David Woodhouse
On Fri, 2023-06-23 at 14:27 +0100, Peter Maydell wrote: > On Thu, 6 Apr 2023 at 17:25, Woodhouse, David wrote: > > > > On Thu, 2023-04-06 at 16:48 +0100, Peter Maydell wrote: > > > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > > > > > From: David Woodhouse > > > > > > > > The way

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-06-23 Thread Peter Maydell
On Thu, 6 Apr 2023 at 17:25, Woodhouse, David wrote: > > On Thu, 2023-04-06 at 16:48 +0100, Peter Maydell wrote: > > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > > > From: David Woodhouse > > > > > > The way that Xen handles MSI PIRQs is kind of awful. > > > > > Now that this is wor

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-04-06 Thread Woodhouse, David
On Thu, 2023-04-06 at 16:48 +0100, Peter Maydell wrote: > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > From: David Woodhouse > > > > The way that Xen handles MSI PIRQs is kind of awful. > > > Now that this is working we can finally enable XENFEAT_hvm_pirqs and > > let the guest us

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-04-06 Thread Peter Maydell
On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > From: David Woodhouse > > The way that Xen handles MSI PIRQs is kind of awful. > Now that this is working we can finally enable XENFEAT_hvm_pirqs and > let the guest use it all. > Hi; Coverity points out a logic error in this code (CID 15076

[PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2023-03-02 Thread Paolo Bonzini
From: David Woodhouse The way that Xen handles MSI PIRQs is kind of awful. There is a special MSI message which targets a PIRQ. The vector in the low bits of data must be zero. The low 8 bits of the PIRQ# are in the destination ID field, the extended destination ID field is unused, and instead t