Re: [PULL 5/9] char: add goldfish-tty

2021-03-15 Thread Laurent Vivier
Le 15/03/2021 à 12:35, Daniel P. Berrangé a écrit : > Nitpick, use 'hw/char' in the subject, as I mistakenly thought > this was touching the char/ backend initially. > I sent a v8 without changing the subject (after this PR but before your comment), but if there is no v9 I will update it in the

Re: [PULL 5/9] char: add goldfish-tty

2021-03-15 Thread Daniel P . Berrangé
Nitpick, use 'hw/char' in the subject, as I mistakenly thought this was touching the char/ backend initially. On Thu, Mar 11, 2021 at 10:09:30PM +0100, Laurent Vivier wrote: > Implement the goldfish tty device as defined in > > https://android.googlesource.com/platform/external/qemu/+/master/doc

Re: [PULL 5/9] char: add goldfish-tty

2021-03-12 Thread Laurent Vivier
Le 11/03/2021 à 23:34, Philippe Mathieu-Daudé a écrit : > On 3/11/21 11:04 PM, Laurent Vivier wrote: >> Le 11/03/2021 à 22:57, Peter Maydell a écrit : >>> On Thu, 11 Mar 2021 at 21:22, Laurent Vivier wrote: Implement the goldfish tty device as defined in https://android.googles

Re: [PULL 5/9] char: add goldfish-tty

2021-03-11 Thread Philippe Mathieu-Daudé
On 3/11/21 11:04 PM, Laurent Vivier wrote: > Le 11/03/2021 à 22:57, Peter Maydell a écrit : >> On Thu, 11 Mar 2021 at 21:22, Laurent Vivier wrote: >>> >>> Implement the goldfish tty device as defined in >>> >>> https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-

Re: [PULL 5/9] char: add goldfish-tty

2021-03-11 Thread Laurent Vivier
Le 11/03/2021 à 22:57, Peter Maydell a écrit : > On Thu, 11 Mar 2021 at 21:22, Laurent Vivier wrote: >> >> Implement the goldfish tty device as defined in >> >> https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT >> >> and based on the kernel driver

Re: [PULL 5/9] char: add goldfish-tty

2021-03-11 Thread Peter Maydell
On Thu, 11 Mar 2021 at 21:22, Laurent Vivier wrote: > > Implement the goldfish tty device as defined in > > https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT > > and based on the kernel driver code: > > https://git.kernel.org/pub/scm/linux/kernel/g

[PULL 5/9] char: add goldfish-tty

2021-03-11 Thread Laurent Vivier
Implement the goldfish tty device as defined in https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT and based on the kernel driver code: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/goldfish.c Signed-off-by: