Re: [PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:08 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 03:47:04PM +0200, Markus Armbruster wrote: >> From: Philippe Mathieu-Daudé >> >> error_propagate_prepend() "behaves like error_prepend()", and >> error_prepend() uses "formatting @fmt, ... like printf()". >> error_prepend() ch

Re: [PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 03:47:04PM +0200, Markus Armbruster wrote: > From: Philippe Mathieu-Daudé > > error_propagate_prepend() "behaves like error_prepend()", and > error_prepend() uses "formatting @fmt, ... like printf()". > error_prepend() checks its format string argument, but > error_propaga

[PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Markus Armbruster
From: Philippe Mathieu-Daudé error_propagate_prepend() "behaves like error_prepend()", and error_prepend() uses "formatting @fmt, ... like printf()". error_prepend() checks its format string argument, but error_propagate_prepend() does not. Fix by addint the format attribute to error_propagate_pr