Re: [PULL 4/4] linux-user: Rewrite do_getdents, do_getdents64

2021-11-11 Thread Richard Henderson
On 11/11/21 12:05 PM, Laurent Vivier wrote: +QEMU_BUILD_BUG_ON(sizeof(*hde) < sizeof(*tde)); Oof, this triggers on i386 host, aarch64 guest. Sorry about that, I'll revise. r~

[PULL 4/4] linux-user: Rewrite do_getdents, do_getdents64

2021-11-11 Thread Laurent Vivier
From: Richard Henderson Always allocate host storage; this ensures that the struct is sufficiently aligned for the host. Merge the three host implementations of getdents via a few ifdefs. Utilize the same method for do_getdents64. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/704 Sig