Re: [PULL 19/25] rust: pl011: switch to safe chardev operation

2025-03-20 Thread Peter Maydell
On Wed, 19 Mar 2025 at 20:51, Paolo Bonzini wrote: > > On 3/19/25 20:25, Peter Maydell wrote: > > Hi -- this commit seems to have broken use of the PL011 in > > boards/SoCs that directly embed it in their state structs, so > > "qemu-system-arm -M raspi2b -display none" now asserts on startup. > >

Re: [PULL 19/25] rust: pl011: switch to safe chardev operation

2025-03-19 Thread Paolo Bonzini
On 3/19/25 20:25, Peter Maydell wrote: On Sun, 9 Mar 2025 at 10:33, Paolo Bonzini wrote: Switch bindings::CharBackend with chardev::CharBackend. This removes occurrences of "unsafe" due to FFI and switches the wrappers for receive, can_receive and event callbacks to the common ones implemente

Re: [PULL 19/25] rust: pl011: switch to safe chardev operation

2025-03-19 Thread Peter Maydell
On Sun, 9 Mar 2025 at 10:33, Paolo Bonzini wrote: > > Switch bindings::CharBackend with chardev::CharBackend. This removes > occurrences of "unsafe" due to FFI and switches the wrappers for receive, > can_receive and event callbacks to the common ones implemented by > chardev::CharBackend. > > Si

[PULL 19/25] rust: pl011: switch to safe chardev operation

2025-03-09 Thread Paolo Bonzini
Switch bindings::CharBackend with chardev::CharBackend. This removes occurrences of "unsafe" due to FFI and switches the wrappers for receive, can_receive and event callbacks to the common ones implemented by chardev::CharBackend. Signed-off-by: Paolo Bonzini --- rust/hw/char/pl011/src/device.r