Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Eric Blake
On Fri, Sep 08, 2023 at 01:42:00PM +0200, Denis V. Lunev wrote: > On 9/8/23 13:24, Denis V. Lunev wrote: > > On 9/8/23 13:03, Stefan Hajnoczi wrote: > > > Please resolve the following CI failure: > > > > > > https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 > > > > > > ../qemu-nbd.c: In func

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Denis V. Lunev
On 9/8/23 13:24, Denis V. Lunev wrote: On 9/8/23 13:03, Stefan Hajnoczi wrote: Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Denis V. Lunev
On 9/8/23 13:03, Stefan Hajnoczi wrote: Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/in

Re: [PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-08 Thread Stefan Hajnoczi
Please resolve the following CI failure: https://gitlab.com/qemu-project/qemu/-/jobs/5045998355 ninja: job failed: cc -m64 -mcx16 -Iqemu-nbd.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fdiagnostics-color=auto -Wall -Winv

[PULL 12/13] qemu-nbd: Restore "qemu-nbd -v --fork" output

2023-09-07 Thread Eric Blake
From: "Denis V. Lunev" Closing stderr earlier is good for daemonized qemu-nbd under ssh earlier, but breaks the case where -v is being used to track what is happening in the server, as in iotest 233. When we know we are verbose, we should preserve original stderr and restore it once the setup st