Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-13 Thread Alex Bennée
Peter Maydell writes: > On Mon, 12 Aug 2024 at 12:10, Alex Bennée wrote: >> >> Peter Maydell writes: >> >> >> >> >> This fails testing: >> >> >> >> https://gitlab.com/qemu-project/qemu/-/jobs/7551982466 >> >> >> >> FAIL: duplicate register {'name': 'PMCCNTR', 'regnum': 96} vs {'name': >> >> '

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-12 Thread Peter Maydell
On Mon, 12 Aug 2024 at 12:10, Alex Bennée wrote: > > Peter Maydell writes: > > > On Sun, 11 Aug 2024 at 22:36, Richard Henderson > > wrote: > >> > >> On 8/10/24 04:08, Peter Maydell wrote: > >> > From: Alex Richardson > >> > diff --git a/target/arm/helper.c b/target/arm/helper.c > >> > index 8f

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-12 Thread Alex Bennée
Peter Maydell writes: > On Sun, 11 Aug 2024 at 22:36, Richard Henderson > wrote: >> >> On 8/10/24 04:08, Peter Maydell wrote: >> > From: Alex Richardson >> > diff --git a/target/arm/helper.c b/target/arm/helper.c >> > index 8fb4b474e83..94900667c33 100644 >> > --- a/target/arm/helper.c >> > +++

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-12 Thread Peter Maydell
On Mon, 12 Aug 2024 at 10:39, Peter Maydell wrote: > > On Sun, 11 Aug 2024 at 22:36, Richard Henderson > wrote: > > > > On 8/10/24 04:08, Peter Maydell wrote: > > > From: Alex Richardson > > > diff --git a/target/arm/helper.c b/target/arm/helper.c > > > index 8fb4b474e83..94900667c33 100644 > >

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-12 Thread Peter Maydell
On Sun, 11 Aug 2024 at 22:36, Richard Henderson wrote: > > On 8/10/24 04:08, Peter Maydell wrote: > > From: Alex Richardson > > diff --git a/target/arm/helper.c b/target/arm/helper.c > > index 8fb4b474e83..94900667c33 100644 > > --- a/target/arm/helper.c > > +++ b/target/arm/helper.c > > @@ -5952

Re: [PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-11 Thread Richard Henderson
On 8/10/24 04:08, Peter Maydell wrote: From: Alex Richardson In the PMUv3, a new AArch32 64-bit (MCRR/MRRC) accessor for the PMCCNTR was added. In QEMU we forgot to implement this, so only provide the 32-bit accessor. Since we have a 64-bit PMCCNTR sysreg for AArch64, adding the 64-bit AArch32

[PULL 09/11] target/arm: add support for PMUv3 64-bit PMCCNTR in AArch32 mode

2024-08-09 Thread Peter Maydell
From: Alex Richardson In the PMUv3, a new AArch32 64-bit (MCRR/MRRC) accessor for the PMCCNTR was added. In QEMU we forgot to implement this, so only provide the 32-bit accessor. Since we have a 64-bit PMCCNTR sysreg for AArch64, adding the 64-bit AArch32 version is easy. We add the PMCCNTR to t