Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On 2024/06/06 16:59, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 04:19:11PM +0900, Akihiko Odaki wrote: On 2024/06/06 16:14, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: On 2024/06/05 19:23, Daniel P. Berrangé wrote: On Tue, Jun 04, 2024 at 03

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On Thu, Jun 06, 2024 at 04:19:11PM +0900, Akihiko Odaki wrote: > On 2024/06/06 16:14, Daniel P. Berrangé wrote: > > On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: > > > On 2024/06/05 19:23, Daniel P. Berrangé wrote: > > > > On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote:

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On 2024/06/06 16:14, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: On 2024/06/05 19:23, Daniel P. Berrangé wrote: On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: From: Akihiko Odaki Propagating ebpf-rss-fds errors has several problems.

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: > On 2024/06/05 19:23, Daniel P. Berrangé wrote: > > On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: > > > From: Akihiko Odaki > > > > > > Propagating ebpf-rss-fds errors has several problems. > > > > > > First, it makes

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On 2024/06/05 19:23, Daniel P. Berrangé wrote: On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: From: Akihiko Odaki Propagating ebpf-rss-fds errors has several problems. First, it makes device realization fail and disables the fallback to the conventional eBPF loading. AFAICT, th

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

On Tue, Jun 04, 2024 at 03:37:42PM +0800, Jason Wang wrote: > From: Akihiko Odaki > > Propagating ebpf-rss-fds errors has several problems. > > First, it makes device realization fail and disables the fallback to the > conventional eBPF loading. AFAICT, this is not a bug - this is desired behav

[PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

From: Akihiko Odaki Propagating ebpf-rss-fds errors has several problems. First, it makes device realization fail and disables the fallback to the conventional eBPF loading. Second, it leaks memory by making device realization fail without freeing memory already allocated. Third, the conventio