Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-10-07 Thread Eric Blake
On 10/7/19 5:48 AM, Vladimir Sementsov-Ogievskiy wrote: We want to wait until listening socket is prepared.. In shell: qemu-nbd --pid-file=/path/to/file ... while [ ! -e /path/to/file ]; do   sleep ... # fractional second, or exponential, or whatever... done # Now the listening socket is in

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-10-07 Thread Vladimir Sementsov-Ogievskiy
04.10.2019 21:05, Eric Blake wrote: > On 9/24/19 3:31 AM, Vladimir Sementsov-Ogievskiy wrote: > +def qemu_nbd_popen(*args): +    '''Run qemu-nbd in daemon mode and return the parent's exit code''' +    return subprocess.Popen(qemu_nbd_args + ['--persistent'] + list(args)) + >>>

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-10-04 Thread Eric Blake
On 9/24/19 3:31 AM, Vladimir Sementsov-Ogievskiy wrote: +def qemu_nbd_popen(*args): +'''Run qemu-nbd in daemon mode and return the parent's exit code''' +return subprocess.Popen(qemu_nbd_args + ['--persistent'] + list(args)) + Should you also use a pid file here, and wait for the exist

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2019 22:51, Eric Blake wrote: > On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: >> Add test, which starts backup to nbd target and restarts nbd server >> during backup. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/264| 65 +

Re: [PATCH v9 3/3] iotests: test nbd reconnect

2019-09-23 Thread Eric Blake
On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote: > Add test, which starts backup to nbd target and restarts nbd server > during backup. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/264| 65 +++ > tests/qemu-iotests/264

[Qemu-devel] [PATCH v9 3/3] iotests: test nbd reconnect

2019-09-17 Thread Vladimir Sementsov-Ogievskiy
Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264| 65 +++ tests/qemu-iotests/264.out| 12 +++ tests/qemu-iotests/group | 1 + tests/qemu-