> >> You have added drawers, books here. Were they missing before?
> >>
> >
> > ...so yes, I think those 2 parameters are missed at this place.
>
> ok. If there is another revision then add a line about this change in the
> commit message. Otherwise it is fine.
>
> Reviewed-by: Babu Moger
>
Su
On 2/29/24 01:32, Zhao Liu wrote:
> Hi Babu,
>
>>> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
>>> "-smp
>>> [[cpus=]n][,maxcpus=maxcpus][,drawers=drawers][,books=books][,sockets=sockets]\n"
>
> Here the "drawers" and "books" are listed...
>
>>> -"
>>> [,dies=dies][,cluster
Hi Babu,
> > DEF("smp", HAS_ARG, QEMU_OPTION_smp,
> > "-smp
> > [[cpus=]n][,maxcpus=maxcpus][,drawers=drawers][,books=books][,sockets=sockets]\n"
Here the "drawers" and "books" are listed...
> > -"
> > [,dies=dies][,clusters=clusters][,cores=cores][,threads=threads]\n"
Hi Zhao,
On 2/27/24 04:32, Zhao Liu wrote:
> From: Zhao Liu
>
> As module-level topology support is added to X86CPU, now we can enable
> the support for the modules parameter on PC machines. With this support,
> we can define a 5-level x86 CPU topology with "-smp":
>
> -smp cpus=*,maxcpus=*,soc
From: Zhao Liu
As module-level topology support is added to X86CPU, now we can enable
the support for the modules parameter on PC machines. With this support,
we can define a 5-level x86 CPU topology with "-smp":
-smp cpus=*,maxcpus=*,sockets=*,dies=*,modules=*,cores=*,threads=*.
Additionally,
