Re: [PATCH v9 07/24] linux-user: Do not call get_errno() in do_brk()

2023-08-04 Thread Richard Henderson
On 8/4/23 16:40, Nathan Egge wrote: The linux-user/syscall.c has many such places where this style check is failing. Should these be fixed in a separate patch? Yes, eventually. r~

[PATCH v9 07/24] linux-user: Do not call get_errno() in do_brk()

2023-08-04 Thread Nathan Egge
On 2023-08-04 18:00, Richard Henderson wrote: From: Akihiko Odaki Later the returned value is compared with -1, and negated errno is not expected. Fixes: 00faf08c95 ("linux-user: Don't use MAP_FIXED in do_brk()") Reviewed-by: Helge Deller Signed-off-by: Akihiko Odaki Message-Id: <20230802071

[PATCH v9 07/24] linux-user: Do not call get_errno() in do_brk()

2023-08-04 Thread Richard Henderson
From: Akihiko Odaki Later the returned value is compared with -1, and negated errno is not expected. Fixes: 00faf08c95 ("linux-user: Don't use MAP_FIXED in do_brk()") Reviewed-by: Helge Deller Signed-off-by: Akihiko Odaki Message-Id: <20230802071754.14876-4-akihiko.od...@daynix.com> Signed-off