Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2022-01-11 Thread Eric DeVolder
Ani, I'll change this from the g_assert_not_reached() back to STATUS_FAILED. Alas I realized I didn't do the last step in producing the new ACPI tables in the patchset, so even though I just put out v12, I'll need to do a followup v13 with the missing tables. Thanks! eric On 1/11/22 02:35, Ani

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2022-01-11 Thread Ani Sinha
On Tue, Dec 14, 2021 at 2:33 AM Eric DeVolder wrote: > > Ani, an inline response below. > Thanks! > eric > > On 12/10/21 08:09, Ani Sinha wrote: > > On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder > > wrote: > >> > >> Ani, inline responses below. eric > >> > >> On 12/9/21 00:29, Ani Sinha wrote: >

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-13 Thread Ani Sinha
On Tue, Dec 14, 2021 at 2:33 AM Eric DeVolder wrote: > > Ani, an inline response below. > Thanks! > eric > > On 12/10/21 08:09, Ani Sinha wrote: > > On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder > > wrote: > >> > >> Ani, inline responses below. eric > >> > >> On 12/9/21 00:29, Ani Sinha wrote: >

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-13 Thread Eric DeVolder
Ani, an inline response below. Thanks! eric On 12/10/21 08:09, Ani Sinha wrote: On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder wrote: Ani, inline responses below. eric On 12/9/21 00:29, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-10 Thread Ani Sinha
On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder wrote: > > Ani, inline responses below. eric > > On 12/9/21 00:29, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of operat

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-09 Thread Eric DeVolder
On 12/9/21 00:31, Ani Sinha wrote: On Wed, Dec 8, 2021 at 10:08 PM Eric DeVolder wrote: On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it i

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-09 Thread Eric DeVolder
Ani, inline responses below. eric On 12/9/21 00:29, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. Few more comments on this

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Ani Sinha
On Wed, Dec 8, 2021 at 10:08 PM Eric DeVolder wrote: > > > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of operation for ERST as it is supported by

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Ani Sinha
On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: > > This implements a PCI device for ACPI ERST. This implements the > non-NVRAM "mode" of operation for ERST as it is supported by > Linux and Windows. Few more comments on this patch ... > > Signed-off-by: Eric DeVolder > --- > hw/acpi/Kcon

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-08 Thread Eric DeVolder
On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. OK sent some more comments. It will take another pass for

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Ani Sinha
On Mon, Dec 6, 2021 at 9:51 PM Eric DeVolder wrote: > > Hi Ani, inline responses below. > eric > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of op

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Ani Sinha
On Mon, Dec 6, 2021 at 9:51 PM Eric DeVolder wrote: > > Hi Ani, inline responses below. > eric > > On 12/6/21 02:14, Ani Sinha wrote: > > On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder > > wrote: > >> > >> This implements a PCI device for ACPI ERST. This implements the > >> non-NVRAM "mode" of op

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Eric DeVolder
Hi Ani, inline responses below. eric On 12/6/21 02:14, Ani Sinha wrote: On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. OK sent some more comm

Re: [PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-06 Thread Ani Sinha
On Fri, Dec 3, 2021 at 12:39 AM Eric DeVolder wrote: > > This implements a PCI device for ACPI ERST. This implements the > non-NVRAM "mode" of operation for ERST as it is supported by > Linux and Windows. OK sent some more comments. It will take another pass for me to fully review this. > > Sign

[PATCH v9 05/10] ACPI ERST: support for ACPI ERST feature

2021-12-02 Thread Eric DeVolder
This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. Signed-off-by: Eric DeVolder --- hw/acpi/Kconfig | 6 + hw/acpi/erst.c | 836 +++ hw/acpi/m