Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-20 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 20.03.2020 16:58, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: [...] >>> I will not be surprised, if we missed some more interesting cases :) >>> But we should proceed. What is our plan? Will you queue v10 for 5.1? >> >> v10's PATCH 1+2

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-20 Thread Vladimir Sementsov-Ogievskiy
20.03.2020 16:58, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 19.03.2020 13:45, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] So, understanding that there no such cases in the whole tree, and even if your patch works faster on the whole tree, I still

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-20 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 19.03.2020 13:45, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: [...] >>> So, understanding that there no such cases in the whole tree, and even >>> if your patch works faster on the whole tree, I still don't want to >>> drop inheritance,

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Vladimir Sementsov-Ogievskiy
19.03.2020 13:45, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 17.03.2020 13:39, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 14.03.2020 00:54, Markus Armbruster wrote:

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 17.03.2020 13:39, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > On 14.03.2020 00:54, Markus Armbruster wrote: >> Vladimir Sementso

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-19 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 14.03.2020 0:54, Markus Armbruster wrote: [...] >> // Match functions with propagation of local error to errp. >> // We want to refer these functions in several following rules, but I >> // don't know a proper way to inherit a function, not just its name >>

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-17 Thread Vladimir Sementsov-Ogievskiy
14.03.2020 0:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now as is.

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-17 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 13:39, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote:

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-17 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 16.03.2020 11:21, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 13.03.2020 18:42, Markus Armbruster wrote: >> Vladimir Sementso

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-17 Thread Vladimir Sementsov-Ogievskiy
16.03.2020 11:21, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote:

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-16 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 14.03.2020 00:54, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 12.03.2020 19:36, Markus Armbruster wrote: >> I may have a seco

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-16 Thread Vladimir Sementsov-Ogievskiy
On 14.03.2020 00:54, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-15 Thread Markus Armbruster
Eric Blake writes: > On 3/13/20 4:54 PM, Markus Armbruster wrote: > >> >> I append my hacked up version of auto-propagated-errp.cocci. It >> produces the same patch as yours for the complete tree. >> >> >> >> // Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h) >> // > >> // >> // Usage example

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Eric Blake
On 3/13/20 4:54 PM, Markus Armbruster wrote: I append my hacked up version of auto-propagated-errp.cocci. It produces the same patch as yours for the complete tree. // Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h) // // // Usage example: // spatch --sp-file scripts/coccinelle/auto-p

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 13.03.2020 18:42, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now as is. Vladimir Sementso

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 18:42, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now as is. Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invo

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 12.03.2020 19:36, Markus Armbruster wrote: >> I may have a second look tomorrow with fresher eyes, but let's get this >> out now as is. >> >> Vladimir Sementsov-Ogievskiy writes: >> >>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 13.03.2020 10:50, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >> [...] >>> +// Warn several Error * definitions. >>> +@check1 disable optional_qualifier exists@ >>> +identifier fn = rule1.fn, local_err, local_err2; >>> +@@ >>> + >>>

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 17:58, Markus Armbruster wrote: I tried this script on the whole tree. Observations: * $ git-diff --shortstat \*.[ch] 333 files changed, 3480 insertions(+), 4586 deletions(-) * Twelve functions have "several definitions of Error * local variable". Eight declare such a variab

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
I tried this script on the whole tree. Observations: * $ git-diff --shortstat \*.[ch] 333 files changed, 3480 insertions(+), 4586 deletions(-) * Twelve functions have "several definitions of Error * local variable". Eight declare such a variable within a loop. Reported because Coccinell

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Vladimir Sementsov-Ogievskiy
13.03.2020 10:50, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] +// Warn several Error * definitions. +@check1 disable optional_qualifier exists@ +identifier fn = rule1.fn, local_err, local_err2; +@@ + + fn(..., Error ** , ...) + { + ... + Error *local_err = N

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: [...] > +// Warn several Error * definitions. > +@check1 disable optional_qualifier exists@ > +identifier fn = rule1.fn, local_err, local_err2; > +@@ > + > + fn(..., Error ** , ...) > + { > + ... > + Error *local_err = NULL; > + ... when any >

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2020 19:36, Markus Armbruster wrote: I may have a second look tomorrow with fresher eyes, but let's get this out now as is. Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in

Re: [PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-12 Thread Markus Armbruster
I may have a second look tomorrow with fresher eyes, but let's get this out now as is. Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for details in > include/qapi/error.h) > > Usage example

[PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \