Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-10-11 Thread Cédric Le Goater
On 10/11/22 09:21, Pierre Morel wrote: On 9/28/22 18:28, Cédric Le Goater wrote: On 9/28/22 18:16, Pierre Morel wrote: More thinking about this I will drop this patch for backward compatibility and in topology masks treat CPUs as being cores*threads yes. You never know, people might have s

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-10-11 Thread Pierre Morel
On 9/28/22 18:28, Cédric Le Goater wrote: On 9/28/22 18:16, Pierre Morel wrote: More thinking about this I will drop this patch for backward compatibility and in topology masks treat CPUs as being cores*threads yes. You never know, people might have set threads=2 in their domain file (like

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-10-10 Thread Pierre Morel
On 9/28/22 20:11, Daniel P. Berrangé wrote: On Fri, Sep 02, 2022 at 09:55:22AM +0200, Pierre Morel wrote: S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU smp commandline. Signed-off-by: Pierre Morel --- hw/s390x/s390-virtio-ccw.c |

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-28 Thread Daniel P . Berrangé
On Fri, Sep 02, 2022 at 09:55:22AM +0200, Pierre Morel wrote: > S390x do not support multithreading in the guest. > Do not let admin falsely specify multithreading on QEMU > smp commandline. > > Signed-off-by: Pierre Morel > --- > hw/s390x/s390-virtio-ccw.c | 3 +++ > 1 file changed, 3 insertion

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-28 Thread Cédric Le Goater
On 9/28/22 18:16, Pierre Morel wrote: More thinking about this I will drop this patch for backward compatibility and in topology masks treat CPUs as being cores*threads yes. You never know, people might have set threads=2 in their domain file (like me). You could give the user a warning though

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-28 Thread Pierre Morel
More thinking about this I will drop this patch for backward compatibility and in topology masks treat CPUs as being cores*threads On 9/28/22 15:21, Pierre Morel wrote: On 9/27/22 11:44, Cédric Le Goater wrote: On 9/5/22 17:10, Pierre Morel wrote: On 9/5/22 13:32, Nico Boehr wrote: Quo

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-28 Thread Pierre Morel
On 9/27/22 11:44, Cédric Le Goater wrote: On 9/5/22 17:10, Pierre Morel wrote: On 9/5/22 13:32, Nico Boehr wrote: Quoting Pierre Morel (2022-09-02 09:55:22) S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU smp commandline. Signed-o

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-27 Thread Cédric Le Goater
On 9/5/22 17:10, Pierre Morel wrote: On 9/5/22 13:32, Nico Boehr wrote: Quoting Pierre Morel (2022-09-02 09:55:22) S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU smp commandline. Signed-off-by: Pierre Morel ---   hw/s390x/s390-virti

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-05 Thread Pierre Morel
On 9/5/22 17:23, Janis Schoetterl-Glausch wrote: On Mon, 2022-09-05 at 17:10 +0200, Pierre Morel wrote: On 9/5/22 13:32, Nico Boehr wrote: Quoting Pierre Morel (2022-09-02 09:55:22) S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU sm

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-05 Thread Janis Schoetterl-Glausch
On Mon, 2022-09-05 at 17:10 +0200, Pierre Morel wrote: > > On 9/5/22 13:32, Nico Boehr wrote: > > Quoting Pierre Morel (2022-09-02 09:55:22) > > > S390x do not support multithreading in the guest. > > > Do not let admin falsely specify multithreading on QEMU > > > smp commandline. > > > > > > Sig

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-05 Thread Pierre Morel
On 9/5/22 13:32, Nico Boehr wrote: Quoting Pierre Morel (2022-09-02 09:55:22) S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU smp commandline. Signed-off-by: Pierre Morel --- hw/s390x/s390-virtio-ccw.c | 3 +++ 1 file changed, 3 i

Re: [PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-05 Thread Nico Boehr
Quoting Pierre Morel (2022-09-02 09:55:22) > S390x do not support multithreading in the guest. > Do not let admin falsely specify multithreading on QEMU > smp commandline. > > Signed-off-by: Pierre Morel > --- > hw/s390x/s390-virtio-ccw.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --gi

[PATCH v9 01/10] s390x/cpus: Make absence of multithreading clear

2022-09-02 Thread Pierre Morel
S390x do not support multithreading in the guest. Do not let admin falsely specify multithreading on QEMU smp commandline. Signed-off-by: Pierre Morel --- hw/s390x/s390-virtio-ccw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c ind