Re: [PATCH v8 7/7] migration/ram: Implement save_postcopy_prepare()

2025-04-04 Thread Prasad Pandit
On Thu, 3 Apr 2025 at 18:37, Fabiano Rosas wrote: > The code assumes some understanding of the multifd sync in general. It > doesn't help that we don't have a high level documentation for that > (yet). If you think the comments at the MultiFDSyncReq are not enough, > feel free to propose a separat

Re: [PATCH v8 7/7] migration/ram: Implement save_postcopy_prepare()

2025-04-03 Thread Fabiano Rosas
Prasad Pandit writes: > Hi, > > On Mon, 31 Mar 2025 at 20:49, Fabiano Rosas wrote: >> > +static bool ram_save_postcopy_prepare(QEMUFile *f, void *opaque, Error >> > **errp) >> > +{ >> > +int ret; >> > + >> > +if (migrate_multifd()) { >> > +/* >> > + * When multifd is ena

Re: [PATCH v8 7/7] migration/ram: Implement save_postcopy_prepare()

2025-04-03 Thread Prasad Pandit
Hi, On Mon, 31 Mar 2025 at 20:49, Fabiano Rosas wrote: > > +static bool ram_save_postcopy_prepare(QEMUFile *f, void *opaque, Error > > **errp) > > +{ > > +int ret; > > + > > +if (migrate_multifd()) { > > +/* > > + * When multifd is enabled, source QEMU needs to make sure

Re: [PATCH v8 7/7] migration/ram: Implement save_postcopy_prepare()

2025-03-31 Thread Fabiano Rosas
Prasad Pandit writes: > From: Peter Xu > > Implement save_postcopy_prepare(), preparing for the enablement of both > multifd and postcopy. > > Please see the rich comment for the rationals. > > Signed-off-by: Peter Xu > Signed-off-by: Prasad Pandit > --- > migration/ram.c | 37 +++

[PATCH v8 7/7] migration/ram: Implement save_postcopy_prepare()

2025-03-18 Thread Prasad Pandit
From: Peter Xu Implement save_postcopy_prepare(), preparing for the enablement of both multifd and postcopy. Please see the rich comment for the rationals. Signed-off-by: Peter Xu Signed-off-by: Prasad Pandit --- migration/ram.c | 37 + 1 file changed, 37