Re: [External] Re: [PATCH v8 4/5] migration: Introduce 'qatzip' compression method

2024-08-26 Thread Prasad Pandit
On Sat, 24 Aug 2024 at 04:22, Yichen Wang wrote: > The patch was originally written exactly like what you suggest, > cleanup in the error path of the same function. However, later I > realized in gdb that I was wrong. The qatzip_send_cleanup() function > will be called later in another thread in b

Re: [External] Re: [PATCH v8 4/5] migration: Introduce 'qatzip' compression method

2024-08-23 Thread Yichen Wang
On Thu, Aug 22, 2024 at 4:06 AM Prasad Pandit wrote: > > Hello, > > On Tue, 20 Aug 2024 at 22:40, Yichen Wang wrote: > > +static int qatzip_send_setup(MultiFDSendParams *p, Error **errp) > > +{ > > +QatzipData *q; > > +QzSessionParamsDeflate_T params; > > +const char *err_msg; > > +

Re: [PATCH v8 4/5] migration: Introduce 'qatzip' compression method

2024-08-22 Thread Prasad Pandit
Hello, On Tue, 20 Aug 2024 at 22:40, Yichen Wang wrote: > +static int qatzip_send_setup(MultiFDSendParams *p, Error **errp) > +{ > +QatzipData *q; > +QzSessionParamsDeflate_T params; > +const char *err_msg; > +int ret; > + > +q = g_new0(QatzipData, 1); > +p->compress_data

[PATCH v8 4/5] migration: Introduce 'qatzip' compression method

2024-08-20 Thread Yichen Wang
From: Bryan Zhang Adds support for 'qatzip' as an option for the multifd compression method parameter, and implements using QAT for 'qatzip' compression and decompression. Acked-by: Markus Armbruster Reviewed-by: Fabiano Rosas Signed-off-by: Bryan Zhang Signed-off-by: Hao Xiang Signed-off-by