Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Klaus Jensen
On Nov 16 19:18, Klaus Jensen wrote: > On Nov 16 09:57, Keith Busch wrote: > > On Thu, Nov 12, 2020 at 08:59:42PM +0100, Klaus Jensen wrote: > > > +static void nvme_aio_err(NvmeRequest *req, int ret) > > > +{ > > > +uint16_t status = NVME_SUCCESS; > > > +Error *local_err = NULL; > > > + > >

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Klaus Jensen
On Nov 16 09:57, Keith Busch wrote: > On Thu, Nov 12, 2020 at 08:59:42PM +0100, Klaus Jensen wrote: > > +static void nvme_aio_err(NvmeRequest *req, int ret) > > +{ > > +uint16_t status = NVME_SUCCESS; > > +Error *local_err = NULL; > > + > > +switch (req->cmd.opcode) { > > +case NVME

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Keith Busch
On Thu, Nov 12, 2020 at 08:59:42PM +0100, Klaus Jensen wrote: > +static void nvme_aio_err(NvmeRequest *req, int ret) > +{ > +uint16_t status = NVME_SUCCESS; > +Error *local_err = NULL; > + > +switch (req->cmd.opcode) { > +case NVME_CMD_READ: > +status = NVME_UNRECOVERED_READ

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Klaus Jensen
On Nov 16 20:36, Minwoo Im wrote: > On 11/12 20:59, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add a new function, nvme_aio_err, to handle errors resulting from AIOs > > and use this from the callbacks. > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 61 ++

Re: [PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-16 Thread Minwoo Im
On 11/12 20:59, Klaus Jensen wrote: > From: Klaus Jensen > > Add a new function, nvme_aio_err, to handle errors resulting from AIOs > and use this from the callbacks. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 61 + > 1 file change

[PATCH v8 2/5] hw/block/nvme: pull aio error handling

2020-11-12 Thread Klaus Jensen
From: Klaus Jensen Add a new function, nvme_aio_err, to handle errors resulting from AIOs and use this from the callbacks. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 61 + 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/hw/