Re: [PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF metadata

2025-04-24 Thread Zhao Liu
> > struct field names starting with an initial capital is > > not the usual QEMU code style. Can this be all initial > > lowercase, with capital just for word separation. > > I think Isaku used such names because they are defined in TDVF Design Guide > spec[1]. > > QEMU's internal data structure

Re: [PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF metadata

2025-04-24 Thread Zhao Liu
On Tue, Apr 01, 2025 at 09:01:27AM -0400, Xiaoyao Li wrote: > Date: Tue, 1 Apr 2025 09:01:27 -0400 > From: Xiaoyao Li > Subject: [PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF > metadata > X-Mailer: git-send-email 2.34.1 > > From: Isaku Yamahata > >

Re: [PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF metadata

2025-04-08 Thread Xiaoyao Li
On 4/2/2025 8:08 PM, Daniel P. Berrangé wrote: On Tue, Apr 01, 2025 at 09:01:27AM -0400, Xiaoyao Li wrote: From: Isaku Yamahata TDX VM needs to boot with its specialized firmware, Trusted Domain Virtual Firmware (TDVF). QEMU needs to parse TDVF and map it in TD guest memory prior to running th

Re: [PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF metadata

2025-04-02 Thread Daniel P . Berrangé
On Tue, Apr 01, 2025 at 09:01:27AM -0400, Xiaoyao Li wrote: > From: Isaku Yamahata > > TDX VM needs to boot with its specialized firmware, Trusted Domain > Virtual Firmware (TDVF). QEMU needs to parse TDVF and map it in TD > guest memory prior to running the TDX VM. > > A TDVF Metadata in TDVF i

[PATCH v8 17/55] i386/tdvf: Introduce function to parse TDVF metadata

2025-04-01 Thread Xiaoyao Li
From: Isaku Yamahata TDX VM needs to boot with its specialized firmware, Trusted Domain Virtual Firmware (TDVF). QEMU needs to parse TDVF and map it in TD guest memory prior to running the TDX VM. A TDVF Metadata in TDVF image describes the structure of firmware. QEMU refers to it to setup memor