RE: [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode

2021-03-14 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 12:32 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 13/35] He

Re: [PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode

2021-02-14 Thread Richard Henderson
On 2/7/21 9:46 PM, Taylor Simpson wrote: > +#define DECODE_MAPPED_REG(REGNO, NAME) \ > +insn->regno[REGNO] = DECODE_REGISTER_##NAME[insn->regno[REGNO]]; The macro argument is not a regno, but an operand number. > +static inline int decode_opcode_can_jump(int opcode) > +{ > +if ((GET_ATTRI

[PATCH v8 13/35] Hexagon (target/hexagon) instruction/packet decode

2021-02-07 Thread Taylor Simpson
Take the words from instruction memory and build a packet_t for TCG code generation The following operations are performed Convert the .new encoded offset to the register number of the producer Reorder the packet so .new producer is before consumer Apply constant extenders Separate