Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-28 Thread Peter Maydell
On Wed, 28 Apr 2021 at 14:29, Markus Armbruster wrote: > > Peter Maydell writes: > > These are two separate things: > > 1) callsites which want to reset some other device, and currently > > mostly use eg device_legacy_reset() -- the transition to be done > > is to move them to use device

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-28 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 28 Apr 2021 at 06:03, Markus Armbruster wrote: >> For what it's worth, Damien further explained the two helpers in >> docs/devel/reset.rst: >> >> For Devices and Buses, the following helper functions exist: >> >> - ``device_cold_reset()`` >> - ``bus_co

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-28 Thread Peter Maydell
On Wed, 28 Apr 2021 at 06:03, Markus Armbruster wrote: > For what it's worth, Damien further explained the two helpers in > docs/devel/reset.rst: > > For Devices and Buses, the following helper functions exist: > > - ``device_cold_reset()`` > - ``bus_cold_reset()`` > > These are si

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-27 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Apr 27, 2021 at 02:21:28PM +0200, Philippe Mathieu-Daudé wrote: >> On 1/23/20 2:28 PM, Damien Hedde wrote: >> > Deprecate device_legacy_reset(), qdev_reset_all() and >> > qbus_reset_all() to be replaced by new functions >> > device_cold_reset() and bus_cold_reset

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-27 Thread Eduardo Habkost
On Tue, Apr 27, 2021 at 02:21:28PM +0200, Philippe Mathieu-Daudé wrote: > On 1/23/20 2:28 PM, Damien Hedde wrote: > > Deprecate device_legacy_reset(), qdev_reset_all() and > > qbus_reset_all() to be replaced by new functions > > device_cold_reset() and bus_cold_reset() which uses resettable API. >

Re: [PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2021-04-27 Thread Philippe Mathieu-Daudé
On 1/23/20 2:28 PM, Damien Hedde wrote: > Deprecate device_legacy_reset(), qdev_reset_all() and > qbus_reset_all() to be replaced by new functions > device_cold_reset() and bus_cold_reset() which uses resettable API. > > Also introduce resettable_cold_reset_fn() which may be used as a > replacemen

[PATCH v8 08/11] hw/core: deprecate old reset functions and introduce new ones

2020-01-23 Thread Damien Hedde
Deprecate device_legacy_reset(), qdev_reset_all() and qbus_reset_all() to be replaced by new functions device_cold_reset() and bus_cold_reset() which uses resettable API. Also introduce resettable_cold_reset_fn() which may be used as a replacement for qdev_reset_all_fn and qbus_reset_all_fn(). Fo