Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-10 Thread Dmitry Osipenko
On 5/10/24 19:12, Dmitry Osipenko wrote: > On 5/10/24 13:56, Akihiko Odaki wrote: >> On 2024/05/09 21:39, Dmitry Osipenko wrote: >>> On 5/5/24 09:37, Akihiko Odaki wrote: On 2024/05/02 4:02, Dmitry Osipenko wrote: > On 4/27/24 08:48, Akihiko Odaki wrote: >>> >>> The VIRTIO_GPU_FILL

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-10 Thread Dmitry Osipenko
On 5/10/24 13:56, Akihiko Odaki wrote: > On 2024/05/09 21:39, Dmitry Osipenko wrote: >> On 5/5/24 09:37, Akihiko Odaki wrote: >>> On 2024/05/02 4:02, Dmitry Osipenko wrote: On 4/27/24 08:48, Akihiko Odaki wrote: >> >> The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is >

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-10 Thread Akihiko Odaki
On 2024/05/09 21:39, Dmitry Osipenko wrote: On 5/5/24 09:37, Akihiko Odaki wrote: On 2024/05/02 4:02, Dmitry Osipenko wrote: On 4/27/24 08:48, Akihiko Odaki wrote: The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by every function processing commands. Changing process_cmd()

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-09 Thread Dmitry Osipenko
On 5/5/24 09:37, Akihiko Odaki wrote: > On 2024/05/02 4:02, Dmitry Osipenko wrote: >> On 4/27/24 08:48, Akihiko Odaki wrote: The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by every function processing commands. Changing process_cmd() to return bool will requ

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-04 Thread Akihiko Odaki
On 2024/05/02 4:02, Dmitry Osipenko wrote: On 4/27/24 08:48, Akihiko Odaki wrote: The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by every function processing commands. Changing process_cmd() to return bool will require to change all those functions. Not worthwhile to change

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-05-01 Thread Dmitry Osipenko
On 4/27/24 08:48, Akihiko Odaki wrote: >> >> The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by >> every function processing commands. Changing process_cmd() to return >> bool will require to change all those functions. Not worthwhile to >> change it, IMO. > >> The flag reflects

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-26 Thread Akihiko Odaki
On 2024/04/24 18:43, Dmitry Osipenko wrote: On 4/19/24 11:53, Akihiko Odaki wrote: On 2024/04/19 4:00, Dmitry Osipenko wrote: Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd processor that it should stop processing commands and retry again next time until flag is unset. Signed-

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-24 Thread Dmitry Osipenko
On 4/19/24 11:53, Akihiko Odaki wrote: > On 2024/04/19 4:00, Dmitry Osipenko wrote: >> Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd >> processor that it should stop processing commands and retry again >> next time until flag is unset. >> >> Signed-off-by: Dmitry Osipenko > > Th

Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-19 Thread Akihiko Odaki
On 2024/04/19 4:00, Dmitry Osipenko wrote: Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd processor that it should stop processing commands and retry again next time until flag is unset. Signed-off-by: Dmitry Osipenko This flag shouldn't be added to virtio_gpu_ctrl_command. s

[PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

2024-04-18 Thread Dmitry Osipenko
Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd processor that it should stop processing commands and retry again next time until flag is unset. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 1 + hw/display/virtio-gpu-rutabaga.c | 1 + hw/display/virtio-gp