RE: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-11 Thread Shashi Mallela
From: Leif LindholmSent: November 11, 2021 1:21 PMTo: Peter MaydellCc: Shashi Mallela; Radoslaw Biernacki; Michael S. Tsirkin; Igor Mammedov; qemu-arm; QEMU Developers; Eric Auger; narmstr...@baylibre.com; Alex Bennée; Marcin JuszkiewiczSubject: Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-11 Thread Leif Lindholm
On Thu, Nov 11, 2021 at 16:55:09 +, Peter Maydell wrote: > On Tue, 9 Nov 2021 at 22:52, Leif Lindholm wrote: > > > > On Tue, Nov 09, 2021 at 21:21:46 +, Peter Maydell wrote: > > > The other thing we should nail down is how the user is going to > > > select which flavour of machine they wan

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-11 Thread Peter Maydell
On Tue, 9 Nov 2021 at 22:52, Leif Lindholm wrote: > > On Tue, Nov 09, 2021 at 21:21:46 +, Peter Maydell wrote: > > The other thing we should nail down is how the user is going to > > select which flavour of machine they want to provide. Three > > options: > > (1) no control, QEMU just emulate

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-09 Thread Leif Lindholm
On Tue, Nov 09, 2021 at 21:21:46 +, Peter Maydell wrote: > > Hmm, right. So you're thinking containing the versioning fully in the > > interfaces presented by the model: > > - Is the version node present? > > - If so, is it greater than X? > > - If so, is it great enough to support the SC

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-09 Thread Peter Maydell
On Tue, 9 Nov 2021 at 20:42, Leif Lindholm wrote: > > On Tue, Nov 09, 2021 at 13:43:50 +, Peter Maydell wrote: > > On Fri, 15 Oct 2021 at 13:23, Leif Lindholm wrote: > > > (Apologies for delay. Alex also tells me you are currently away, but > > > there is no strong urgency here.) > > > > (Tha

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-09 Thread Leif Lindholm
On Tue, Nov 09, 2021 at 13:43:50 +, Peter Maydell wrote: > On Fri, 15 Oct 2021 at 13:23, Leif Lindholm wrote: > > (Apologies for delay. Alex also tells me you are currently away, but > > there is no strong urgency here.) > > (Thanks for the ping via Alex -- I missed this email when I was > sc

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-11-09 Thread Peter Maydell
On Fri, 15 Oct 2021 at 13:23, Leif Lindholm wrote: > (Apologies for delay. Alex also tells me you are currently away, but > there is no strong urgency here.) (Thanks for the ping via Alex -- I missed this email when I was scanning through my qemu-devel mail backlog after my holiday...) > On Thu,

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-10-15 Thread Leif Lindholm
Hi Peter, (Apologies for delay. Alex also tells me you are currently away, but there is no strong urgency here.) On Thu, Sep 23, 2021 at 17:00:35 +0100, Peter Maydell wrote: > > If we assume that we don't want to further complicate this set by > > adding the additional logic *now*, I see three op

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-09-23 Thread Peter Maydell
On Thu, 2 Sept 2021 at 13:43, Leif Lindholm wrote: > Hmm. I mean, you're absolutely right about the complexity and need for > discussion. My concern is that we cannot insert the ITS block in the > memory map where it would be in an ARM GIC implementation without > changing the memory map (pushing

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-09-03 Thread Peter Maydell
On Fri, 3 Sept 2021 at 13:01, Leif Lindholm wrote: > On Thu, Sep 02, 2021 at 13:51:26 +0100, Peter Maydell wrote: > > How does guest software on this board figure out the memory > > layout ? Is there a mechanism for telling it "this is version 2 > > of this board" ? > > Not currently. Aiming to lo

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-09-03 Thread Leif Lindholm
On Thu, Sep 02, 2021 at 13:51:26 +0100, Peter Maydell wrote: > On Thu, 2 Sept 2021 at 13:43, Leif Lindholm wrote: > > On Thu, Aug 19, 2021 at 14:27:19 +0100, Peter Maydell wrote: > > > If you want a command line switch to let the user say whether the > > > ITS should be present or not, you should

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-09-02 Thread Peter Maydell
On Thu, 2 Sept 2021 at 13:43, Leif Lindholm wrote: > On Thu, Aug 19, 2021 at 14:27:19 +0100, Peter Maydell wrote: > > If you want a command line switch to let the user say whether the > > ITS should be present or not, you should use the same thing the > > virt board does, which is a bool property

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-09-02 Thread Leif Lindholm
Hi Peter, On Thu, Aug 19, 2021 at 14:27:19 +0100, Peter Maydell wrote: > On Thu, 12 Aug 2021 at 17:53, Shashi Mallela > wrote: > > > > Included creation of ITS as part of SBSA platform GIC > > initialization. > > > > Signed-off-by: Shashi Mallela > > --- > > hw/arm/sbsa-ref.c | 79

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-08-23 Thread shashi . mallela
On Thu, 2021-08-19 at 14:27 +0100, Peter Maydell wrote: > On Thu, 12 Aug 2021 at 17:53, Shashi Mallela < > shashi.mall...@linaro.org> wrote: > > Included creation of ITS as part of SBSA platform GIC > > initialization. > > > > Signed-off-by: Shashi Mallela > > --- > > hw/arm/sbsa-ref.c | 79 > >

Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-08-19 Thread Peter Maydell
On Thu, 12 Aug 2021 at 17:53, Shashi Mallela wrote: > > Included creation of ITS as part of SBSA platform GIC > initialization. > > Signed-off-by: Shashi Mallela > --- > hw/arm/sbsa-ref.c | 79 --- > 1 file changed, 75 insertions(+), 4 deletions(-) >

[PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-08-12 Thread Shashi Mallela
Included creation of ITS as part of SBSA platform GIC initialization. Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 79 --- 1 file changed, 75 insertions(+), 4 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c1629df603..f