Re: [PATCH v8 03/21] error: make Error **errp const where it is appropriate

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Mostly, Error ** is for returning error from the function, so the > callee sets it. However these three functions get already filled errp > parameter. They dont change the pointer itself, only change the > internal state of referenced Error object. So we can

Re: [PATCH v8 03/21] error: make Error **errp const where it is appropriate

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote: Mostly, Error ** is for returning error from the function, so the callee sets it. However these three functions get already filled errp parameter. They dont change the pointer itself, only change the internal state of referenced Error object

[PATCH v8 03/21] error: make Error **errp const where it is appropriate

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
Mostly, Error ** is for returning error from the function, so the callee sets it. However these three functions get already filled errp parameter. They dont change the pointer itself, only change the internal state of referenced Error object. So we can make it Error *const * errp, to stress the beh