Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-06 Thread Mark Cave-Ayland
On 28/08/2023 20:55, Emmanouil Pitsidianakis wrote: Hi Emmanouil, Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 13:46, Manos Pitsidianakis wrote: On Mon, 04 Sep 2023 14:30, Philippe Mathieu-Daudé wrote: On 4/9/23 13:00, Manos Pitsidianakis wrote: On Mon, 04 Sep 2023 13:46, Philippe Mathieu-Daudé wrote: +    size_t sz = iov_to_buf(cmd->elem->out_sg, +   cmd->elem->out_

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Manos Pitsidianakis
On Mon, 04 Sep 2023 14:30, Philippe Mathieu-Daudé wrote: On 4/9/23 13:00, Manos Pitsidianakis wrote: On Mon, 04 Sep 2023 13:46, Philippe Mathieu-Daudé wrote: +    size_t sz = iov_to_buf(cmd->elem->out_sg, +   cmd->elem->out_num, +   0, +

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 13:00, Manos Pitsidianakis wrote: On Mon, 04 Sep 2023 13:46, Philippe Mathieu-Daudé wrote: +    size_t sz = iov_to_buf(cmd->elem->out_sg, +   cmd->elem->out_num, +   0, +   &cmd->ctrl, +  

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Manos Pitsidianakis
On Mon, 04 Sep 2023 13:46, Philippe Mathieu-Daudé wrote: +size_t sz = iov_to_buf(cmd->elem->out_sg, + cmd->elem->out_num, + 0, + &cmd->ctrl, + sizeof(cmd->ctrl)); +if (sz != sizeof(cmd

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Philippe Mathieu-Daudé
On 28/8/23 21:55, Emmanouil Pitsidianakis wrote: Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the queue in the devic

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Philippe Mathieu-Daudé
On 4/9/23 12:18, Manos Pitsidianakis wrote: Good morning Philippe, On Mon, 04 Sep 2023 13:08, Philippe Mathieu-Daudé wrote: +    iov_from_buf(cmd->elem->in_sg, + cmd->elem->in_num, + 0, + &cmd->resp, + sizeof(cmd->resp)); +    vi

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Manos Pitsidianakis
Good morning Philippe, On Mon, 04 Sep 2023 13:08, Philippe Mathieu-Daudé wrote: +iov_from_buf(cmd->elem->in_sg, + cmd->elem->in_num, + 0, + &cmd->resp, + sizeof(cmd->resp)); +virtqueue_push(cmd->vq, cmd->elem, sizeof(cmd->e

Re: [PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-09-04 Thread Philippe Mathieu-Daudé
Hi Emmanouil, On 28/8/23 21:55, Emmanouil Pitsidianakis wrote: Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the que

[PATCH v8 03/12] virtio-sound: handle control messages and streams

2023-08-28 Thread Emmanouil Pitsidianakis
Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the queue in the device's command queue. Then it calls virtio_snd_process