Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Jonah Palmer
On 11/5/21 03:26, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Ori

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Markus Armbruster
This series increases total size (text + data + bss) by 134KiB for me. QAPI clearly was not designed for space efficiency. Still, it's a drop in the bucket. If debugging commands ever become a burden for certain use cases, we can think about making them compile-time optional.

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: >> This series introduces new QMP/HMP commands to dump the status of a >> virtio device at different levels. >> >> [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches >> are from Laurent

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-10-28 Thread Dr. David Alan Gilbert
* Jonah Palmer (jonah.pal...@oracle.com) wrote: > > On 10/27/21 07:55, Daniel P. Berrangé wrote: > > On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: > > > This series introduces new QMP/HMP commands to dump the status of a > > > virtio device at different levels. > > > > > > [Jonah:

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-10-28 Thread Jonah Palmer
On 10/27/21 07:55, Daniel P. Berrangé wrote: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches are from Lau

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-10-27 Thread Daniel P . Berrangé
On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: > This series introduces new QMP/HMP commands to dump the status of a > virtio device at different levels. > > [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches > are from Laurent Vivier from May 2020. > > Rebase

[PATCH v8 0/8] hmp,qmp: Add commands to introspect virtio devices

2021-10-27 Thread Jonah Palmer
This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches are from Laurent Vivier from May 2020. Rebase from v7 to v8 includes an additional assert to make sure we're not returnin