Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 20:14, Eric Blake wrote: >> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The local_err parameter is not here to return information about >>> nbd_iter_channel_error failure. Instead it's assumed to be filled when >>> passed to the fu

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

06.12.2019 11:54, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 05.12.2019 20:14, Eric Blake wrote: >>> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

On 12/5/19 12:09 PM, Vladimir Sementsov-Ogievskiy wrote: All callers of nbd_iter_channel_error() pass the address of a local_err variable, and only call this function if an error has already occurred, using this function to append details to that error. Hmm, not to append details but to

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

05.12.2019 20:49, Eric Blake wrote: > On 12/5/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 20:14, Eric Blake wrote: >>> On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure.

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

On 12/5/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote: 05.12.2019 20:14, Eric Blake wrote: On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed to be filled when passed to t

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

05.12.2019 20:14, Eric Blake wrote: > On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> The local_err parameter is not here to return information about >> nbd_iter_channel_error failure. Instead it's assumed to be filled when >> passed to the function. This is already stressed by its name

Re: [PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

On 12/5/19 9:20 AM, Vladimir Sementsov-Ogievskiy wrote: The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed to be filled when passed to the function. This is already stressed by its name (local_err, instead of classic errp). Stress

[PATCH v7 21/21] nbd: assert that Error** is not NULL in nbd_iter_channel_error

The local_err parameter is not here to return information about nbd_iter_channel_error failure. Instead it's assumed to be filled when passed to the function. This is already stressed by its name (local_err, instead of classic errp). Stress it additionally by assertion. Signed-off-by: Vladimir Sem