Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-16 Thread Laszlo Ersek
On 06/15/20 17:02, Philippe Mathieu-Daudé wrote: > On 6/15/20 4:45 PM, Gerd Hoffmann wrote: >> Hi, >> I can explain the rationale for that change, but I'm not sure of the answer to your question. That changes makes sure that the fw_cfg data remains exactly the same even on newer v

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/15/20 4:45 PM, Gerd Hoffmann wrote: > Hi, > >>> I can explain the rationale for that change, but I'm not sure of the >>> answer to your question. That changes makes sure that the fw_cfg data >>> remains exactly the same even on newer versions of qemu if the machine >>> is set the same. Th

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-15 Thread Gerd Hoffmann
Hi, > > I can explain the rationale for that change, but I'm not sure of the > > answer to your question. That changes makes sure that the fw_cfg data > > remains exactly the same even on newer versions of qemu if the machine > > is set the same. This way you can do migrations to newer qemu ve

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-11 Thread Corey Minyard
On Thu, Jun 11, 2020 at 01:49:31PM +0200, Philippe Mathieu-Daudé wrote: > On 6/11/20 1:31 PM, Laszlo Ersek wrote: > > On 06/09/20 17:50, Corey Minyard wrote: > >> On Fri, May 29, 2020 at 11:50:24AM +0200, Laszlo Ersek wrote: > >>> Gerd, Corey: there's a question for you near the end, please. > >>>

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 1:31 PM, Laszlo Ersek wrote: > On 06/09/20 17:50, Corey Minyard wrote: >> On Fri, May 29, 2020 at 11:50:24AM +0200, Laszlo Ersek wrote: >>> Gerd, Corey: there's a question for you near the end, please. >>> >>> On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> >> snip... >> >>> >>> >>>

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-11 Thread Laszlo Ersek
On 06/09/20 17:50, Corey Minyard wrote: > On Fri, May 29, 2020 at 11:50:24AM +0200, Laszlo Ersek wrote: >> Gerd, Corey: there's a question for you near the end, please. >> >> On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > > snip... > >> >> >> (3) I've noticed another *potential* issue, from l

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-09 Thread Corey Minyard
On Fri, May 29, 2020 at 11:50:24AM +0200, Laszlo Ersek wrote: > Gerd, Corey: there's a question for you near the end, please. > > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: snip... > > > (3) I've noticed another *potential* issue, from looking at the larger > context. I apologize for mis

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-06-09 Thread Philippe Mathieu-Daudé
On 5/29/20 11:50 AM, Laszlo Ersek wrote: > Gerd, Corey: there's a question for you near the end, please. > > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> The 'gen_id' argument refers to a QOM object able to produce >> data consumable by the fw_cfg device. The producer object must >> impleme

Re: [PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-05-29 Thread Laszlo Ersek
Gerd, Corey: there's a question for you near the end, please. On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > The 'gen_id' argument refers to a QOM object able to produce > data consumable by the fw_cfg device. The producer object must > implement the FW_CFG_DATA_GENERATOR interface. > > Signed

[PATCH v7 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument

2020-05-28 Thread Philippe Mathieu-Daudé
The 'gen_id' argument refers to a QOM object able to produce data consumable by the fw_cfg device. The producer object must implement the FW_CFG_DATA_GENERATOR interface. Signed-off-by: Philippe Mathieu-Daudé --- v7: - renamed 'blob_id' -> 'gen_id' (danpb) - update comment in code (lersek) - fixe